-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace]Fix error message missed in workspace creator name input #8738
[Workspace]Fix error message missed in workspace creator name input #8738
Conversation
Signed-off-by: Lin Wang <[email protected]>
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8738 +/- ##
==========================================
- Coverage 60.78% 60.78% -0.01%
==========================================
Files 3798 3798
Lines 90701 90701
Branches 14284 14284
==========================================
- Hits 55136 55132 -4
- Misses 32065 32068 +3
- Partials 3500 3501 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cypress-10 is known issue |
…8738) * Fix error message missed in workspace creator name input Signed-off-by: Lin Wang <[email protected]> * Changeset file for PR #8738 created/updated --------- Signed-off-by: Lin Wang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 1b3e60c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…8738) (#8824) * Fix error message missed in workspace creator name input * Changeset file for PR #8738 created/updated --------- (cherry picked from commit 1b3e60c) Signed-off-by: Lin Wang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Description
This PR is for fixing error message missed in workspace creator name and color input.
Screenshot
Testing the changes
yarn osd bootstrap --single-version loose
config/opensearch_dashboards.yml
yarn start --no-base-path
Changelog
-fix: [Workspace]Fix error message missed in workspace creator name input
Check List
yarn test:jest
yarn test:jest_integration