Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace]Fix error message missed in workspace creator name input #8738

Conversation

wanglam
Copy link
Contributor

@wanglam wanglam commented Oct 29, 2024

Description

This PR is for fixing error message missed in workspace creator name and color input.

Screenshot

image

Testing the changes

  • Clone branch code and run yarn osd bootstrap --single-version loose
  • Add below configs in config/opensearch_dashboards.yml
savedObjects.permission.enabled: true
workspace.enabled: true
uiSettings:
  overrides:
    'home:useNewHomePage': true
opensearchDashboards.dashboardAdmin.users: ['admin']
  • Run yarn start --no-base-path
  • Login with admin user and go to workspace create page by bottom left menu
  • Click the workspace create button and the name input error should be displayed

Changelog

-fix: [Workspace]Fix error message missed in workspace creator name input

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@wanglam wanglam changed the title Fix error message missed in workspace creator name input [Workspace]Fix error message missed in workspace creator name input Oct 29, 2024
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.78%. Comparing base (4f6b287) to head (de6f890).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8738      +/-   ##
==========================================
- Coverage   60.78%   60.78%   -0.01%     
==========================================
  Files        3798     3798              
  Lines       90701    90701              
  Branches    14284    14284              
==========================================
- Hits        55136    55132       -4     
- Misses      32065    32068       +3     
- Partials     3500     3501       +1     
Flag Coverage Δ
Linux_1 29.05% <ø> (ø)
Linux_2 56.39% <ø> (ø)
Linux_3 37.65% <ø> (-0.01%) ⬇️
Linux_4 29.82% <ø> (ø)
Windows_1 29.06% <ø> (ø)
Windows_2 56.34% <ø> (ø)
Windows_3 37.65% <ø> (ø)
Windows_4 29.82% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hailong-am
Copy link
Collaborator

cypress-10 is known issue

@Hailong-am Hailong-am merged commit 1b3e60c into opensearch-project:main Nov 7, 2024
67 of 69 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 7, 2024
…8738)

* Fix error message missed in workspace creator name input

Signed-off-by: Lin Wang <[email protected]>

* Changeset file for PR #8738 created/updated

---------

Signed-off-by: Lin Wang <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 1b3e60c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Hailong-am pushed a commit that referenced this pull request Nov 8, 2024
…8738) (#8824)

* Fix error message missed in workspace creator name input



* Changeset file for PR #8738 created/updated

---------



(cherry picked from commit 1b3e60c)

Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants