Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed ppl polling; save dataset in saved queries #8724

Merged
merged 2 commits into from
Oct 29, 2024
Merged

fixed ppl polling; save dataset in saved queries #8724

merged 2 commits into from
Oct 29, 2024

Conversation

amsiglan
Copy link
Collaborator

Description

This PR fixes two issues:

  1. Passes required params when polling for PPL results
  2. Saves dataset in saved query when query enhancements is enabled

Changelog

  • fix: Polling for PPL results; Saved dataset to saved queries

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@amsiglan amsiglan marked this pull request as ready for review October 28, 2024 20:52
@codecov Codecov
Copy link

codecov bot commented Oct 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.74%. Comparing base (54fd87d) to head (c62ae32).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...ta/public/query/saved_query/saved_query_service.ts 40.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8724      +/-   ##
==========================================
- Coverage   60.74%   60.74%   -0.01%     
==========================================
  Files        3798     3798              
  Lines       90662    90664       +2     
  Branches    14260    14261       +1     
==========================================
+ Hits        55072    55073       +1     
  Misses      32093    32093              
- Partials     3497     3498       +1
Flag Coverage Δ
Linux_1 29.06% <0.00%> (-0.01%) ⬇️
Linux_2 56.39% <ø> (ø)
Linux_3 37.58% <40.00%> (+<0.01%) ⬆️
Linux_4 29.83% <0.00%> (-0.01%) ⬇️
Windows_1 29.08% <0.00%> (-0.01%) ⬇️
Windows_2 56.34% <ø> (ø)
Windows_3 37.58% <40.00%> (+<0.01%) ⬆️
Windows_4 29.83% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

virajsanghvi
virajsanghvi approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@virajsanghvi virajsanghvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock, but what is the plan to address patch coverage check?

@amsiglan amsiglan merged commit 48bfe2c into opensearch-project:main Oct 29, 2024
71 of 72 checks passed
@amsiglan
Copy link
Collaborator Author

Approving to unblock, but what is the plan to address patch coverage check?

Adding tests in a follow up PR

opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 29, 2024
@github-actions @opensearch-changeset-bot
fixed ppl polling; save dataset in saved queries (#8724)
7bc54dd 
* fixed ppl polling; save dataset in saved queries

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* Changeset file for PR #8724 created/updated

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 48bfe2c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 29, 2024
Merged
Qxisylolo pushed a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Oct 30, 2024
@amsiglan @opensearch-changeset-bot @Qxisylolo
fixed ppl polling; save dataset in saved queries (opensearch-project#…
2002e79 
…8724)

* fixed ppl polling; save dataset in saved queries

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* Changeset file for PR opensearch-project#8724 created/updated

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
@ananzh ananzh added v2.18.0 and removed v2.19.0 labels Oct 30, 2024
ananzh pushed a commit that referenced this pull request Oct 30, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
fixed ppl polling; save dataset in saved queries (#8724) (#8745)
103bd2d 
* fixed ppl polling; save dataset in saved queries



* Changeset file for PR #8724 created/updated

---------



(cherry picked from commit 48bfe2c)

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goyamegh goyamegh goyamegh left review comments

@joshuali925 joshuali925 joshuali925 approved these changes

@ashwin-pc ashwin-pc ashwin-pc approved these changes

@virajsanghvi virajsanghvi virajsanghvi approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
backport 2.x v2.18.0 valued-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@amsiglan @virajsanghvi @ashwin-pc @joshuali925 @goyamegh @ananzh