-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace] [Bug] Fix index pattern issue #8718
[Workspace] [Bug] Fix index pattern issue #8718
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8718 +/- ##
==========================================
- Coverage 60.74% 60.74% -0.01%
==========================================
Files 3798 3798
Lines 90660 90662 +2
Branches 14259 14259
==========================================
Hits 55072 55072
- Misses 32092 32093 +1
- Partials 3496 3497 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: yubonluo <[email protected]>
a42c381
to
ea66730
Compare
Does this need a backport? |
Yes, this pr needs to be backported into 2.x. |
Signed-off-by: yubonluo <[email protected]> (cherry picked from commit 815f466) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: yubonluo <[email protected]> (cherry picked from commit 815f466) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 815f466) Signed-off-by: yubonluo <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 815f466) Signed-off-by: yubonluo <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: yubonluo <[email protected]>
Description
Fix index pattern issue:
When workspace is enabled, there should not be a global default index pattern setting, the "Set as default" button should not be displayed in "Global assets" → "inspect" page.
The current workspace default index pattern setting extends the global value, but this is not expected, we should fix this by not extending from global setting for workspace default index pattern. If non-workspace-admin user has no the permission of the global index pattern and the default index pattern of workspace level, they can not load the dashboard
Inspect button should go to the link inside a workspace.
Issues Resolved
N/A
Screenshot
4a3131c0-94ee-11ef-a923-9f39d35cdf7c_b4c0b625-ee20-4afd-aa13-da0866f0b117
There is no default index pattern in the current workspace and current user have no the permission of the global index pattern, the dashboard page should load normally
2024-10-28.18.16.00.mp4
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration