Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Update auto-complete-api-with-mds #8713

Merged
merged 3 commits into from
Oct 28, 2024
Merged

[Enhancement] Update auto-complete-api-with-mds #8713

merged 3 commits into from
Oct 28, 2024

Conversation

sumukhswamy
Copy link
Contributor

@sumukhswamy sumukhswamy commented Oct 27, 2024 •
edited
Loading

Description

Value suggestion api did not have the MDS support added that in the api

![image](https://github.com/user-attachments/assets/c

Uploading Screen Recording 2024-10-28 at 10.02.39 AM.mov…

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@github-actions GitHub Actions
Copy link
Contributor

ℹ️ Manual Changeset Creation Reminder

Please ensure manual commit for changeset file 8713.yml under folder changelogs/fragments to complete this PR.

If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link.

For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool.

@sumukhswamy
added changelog
b7651e5 
Signed-off-by: sumukhswamy <[email protected]>
ashwin-pc
ashwin-pc approved these changes Oct 27, 2024
View reviewed changes
Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would be nice if someone from the MDS team reviewed this as well, but should not be an issue ideally.

@codecov Codecov
Copy link

codecov bot commented Oct 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 60.73%. Comparing base (463a6c0) to head (b7651e5).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
...ata/server/autocomplete/value_suggestions_route.ts 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8713      +/-   ##
==========================================
- Coverage   60.75%   60.73%   -0.02%     
==========================================
  Files        3798     3798              
  Lines       90650    90653       +3     
  Branches    14254    14256       +2     
==========================================
- Hits        55076    55062      -14     
- Misses      32079    32096      +17     
  Partials     3495     3495
Flag Coverage Δ
Linux_1 29.06% <0.00%> (-0.01%) ⬇️
Linux_2 56.39% <0.00%> (-0.01%) ⬇️
Linux_3 37.57% <28.57%> (-0.01%) ⬇️
Linux_4 29.83% <0.00%> (-0.01%) ⬇️
Windows_1 29.08% <0.00%> (-0.02%) ⬇️
Windows_2 56.34% <0.00%> (-0.01%) ⬇️
Windows_3 37.57% <28.57%> (-0.01%) ⬇️
Windows_4 29.83% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanyl ruanyl merged commit c105d94 into opensearch-project:main Oct 28, 2024
71 of 72 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 28, 2024
@github-actions
[Enhancement] Update auto-complete-api-with-mds (#8713)
54676cb 
* Update auto-complete-api-with-mds

Signed-off-by: sumukhswamy <[email protected]>

* Update auto-complete-api-with-mds

Signed-off-by: sumukhswamy <[email protected]>

* added changelog

Signed-off-by: sumukhswamy <[email protected]>

---------

Signed-off-by: sumukhswamy <[email protected]>
(cherry picked from commit c105d94)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 28, 2024
Merged
@sumukhswamy
Copy link
Contributor Author

Screen.Recording.2024-10-28.at.10.02.39.AM.mov

@sumukhswamy
Copy link
Contributor Author

Screen.Recording.2024-10-27.at.4.21.14.PM.mov

Qxisylolo pushed a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Oct 30, 2024
@sumukhswamy @Qxisylolo
[Enhancement] Update auto-complete-api-with-mds (opensearch-project#8713
f66cda9 
)

* Update auto-complete-api-with-mds

Signed-off-by: sumukhswamy <[email protected]>

* Update auto-complete-api-with-mds

Signed-off-by: sumukhswamy <[email protected]>

* added changelog

Signed-off-by: sumukhswamy <[email protected]>

---------

Signed-off-by: sumukhswamy <[email protected]>
@ananzh ananzh added v2.18.0 and removed v2.19.0 labels Oct 30, 2024
ananzh pushed a commit that referenced this pull request Oct 30, 2024
@opensearch-trigger-bot @github-actions
[Enhancement] Update auto-complete-api-with-mds (#8713) (#8717)
2d2bf4a 
* Update auto-complete-api-with-mds



* Update auto-complete-api-with-mds



* added changelog



---------


(cherry picked from commit c105d94)

Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanL1997 RyanL1997 RyanL1997 approved these changes

@raintygao raintygao raintygao approved these changes

@ashwin-pc ashwin-pc ashwin-pc approved these changes

@ruanyl ruanyl ruanyl approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
backport 2.x repeat-contributor v2.18.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sumukhswamy @ruanyl @ashwin-pc @raintygao @RyanL1997 @ananzh