Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [Workspace] Integrate workspace front end with data connection type saved object #8269

Merged
merged 1 commit into from
Sep 24, 2024
Merged

[Backport 2.x] [Workspace] Integrate workspace front end with data connection type saved object #8269

merged 1 commit into from
Sep 24, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport c894584 from #8013.

@github-actions @opensearch-changeset-bot @SuZhou-Joe
[Workspace] Integrate workspace front end with data connection type s…
7166598 
…aved object (#8013)

* feat: integrate workspace with data connections

Signed-off-by: tygao <[email protected]>

* update workspace pages and hooks to integrate with data connection

Signed-off-by: tygao <[email protected]>

* Changeset file for PR #8013 created/updated

* remove extra comments

Signed-off-by: tygao <[email protected]>

* update data source import

Signed-off-by: tygao <[email protected]>

* test: update tests

Signed-off-by: tygao <[email protected]>

* Changeset file for PR #8013 created/updated

* unify connection type icon and connectionType

Signed-off-by: tygao <[email protected]>

* test: add tests

Signed-off-by: tygao <[email protected]>

* display text directly instead of link for data connection in table

Signed-off-by: tygao <[email protected]>

* Apply suggestions from code review

Co-authored-by: SuZhou-Joe <[email protected]>
Signed-off-by: Tianyu Gao <[email protected]>

* update

Signed-off-by: tygao <[email protected]>

---------

Signed-off-by: tygao <[email protected]>
Signed-off-by: Tianyu Gao <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: SuZhou-Joe <[email protected]>
(cherry picked from commit c894584)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot added autocut Skip the changelog verification check on backports all-star-contributor workspace 2.17.1 labels Sep 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@codecov Codecov
Copy link

codecov bot commented Sep 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 64.15%. Comparing base (e0e9f5b) to head (7166598).
Report is 11 commits behind head on 2.x.

Files with missing lines Patch % Lines
src/plugins/workspace/public/utils.ts 87.50% 2 Missing ⚠️
...components/workspace_form/connection_type_icon.tsx 85.71% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              2.x    #8269      +/-   ##
==========================================
+ Coverage   64.14%   64.15%   +0.01%     
==========================================
  Files        3740     3740              
  Lines       88674    88694      +20     
  Branches    13806    13812       +6     
==========================================
+ Hits        56877    56904      +27     
+ Misses      31186    31179       -7     
  Partials      611      611
Flag Coverage Δ
Linux_1 30.08% <91.66%> (+0.03%) ⬆️
Linux_2 58.97% <ø> (ø)
Linux_3 40.38% <ø> (ø)
Linux_4 31.55% <ø> (ø)
Windows_1 30.10% <91.66%> (+0.03%) ⬆️
Windows_2 58.92% <ø> (ø)
Windows_3 40.38% <ø> (ø)
Windows_4 31.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanyl ruanyl merged commit 6ea0cb4 into 2.x Sep 24, 2024
68 of 70 checks passed
yubonluo pushed a commit to yubonluo/OpenSearch-Dashboards that referenced this pull request Sep 25, 2024
@opensearch-trigger-bot @github-actions
@opensearch-changeset-bot @SuZhou-Joe @yubonluo
[Workspace] Integrate workspace front end with data connection type s…
580ec5b 
…aved object (opensearch-project#8013) (opensearch-project#8269)

* feat: integrate workspace with data connections



* update workspace pages and hooks to integrate with data connection



* Changeset file for PR opensearch-project#8013 created/updated

* remove extra comments



* update data source import



* test: update tests



* Changeset file for PR opensearch-project#8013 created/updated

* unify connection type icon and connectionType



* test: add tests



* display text directly instead of link for data connection in table



* Apply suggestions from code review




* update



---------





(cherry picked from commit c894584)

Signed-off-by: tygao <[email protected]>
Signed-off-by: Tianyu Gao <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: SuZhou-Joe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@ruanyl ruanyl ruanyl approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
2.17.1 all-star-contributor autocut Skip the changelog verification check on backports failed changeset workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruanyl @SuZhou-Joe