[workspace]feat: validate workspace when find objects #8268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
Signed-off-by: SuZhou-Joe <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8268 +/- ##
==========================================
+ Coverage 64.04% 64.11% +0.07%
==========================================
Files 3740 3744 +4
Lines 88582 88857 +275
Branches 13791 13852 +61
==========================================
+ Hits 56731 56974 +243
- Misses 31253 31270 +17
- Partials 598 613 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wanglam
reviewed
Sep 20, 2024
src/plugins/workspace/server/saved_objects/workspace_id_consumer_wrapper.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: SuZhou-Joe <[email protected]>
Hailong-am
reviewed
Sep 20, 2024
src/plugins/workspace/server/saved_objects/workspace_id_consumer_wrapper.ts
Outdated
Show resolved
Hide resolved
ruanyl
reviewed
Sep 20, 2024
src/plugins/workspace/server/saved_objects/workspace_id_consumer_wrapper.ts
Outdated
Show resolved
Hide resolved
| ); | ||
| : this.formatWorkspaceIdParams(wrapperOptions.request, options); | ||
| if (finalOptions.workspaces?.length) { | ||
| const workspaceList = await this.workspaceClient.list( |
There was a problem hiding this comment.
Shall we simply call wrapperOptions.client.find with WORKSPACE_TYPE to get the the workspace list? Just thinking might be better to not introduce another dependency to saved object client wrapper.
There was a problem hiding this comment.
We can not because workspace is a hidden type.
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
ruanyl
approved these changes
Sep 24, 2024
wanglam
approved these changes
Sep 25, 2024
Hailong-am
approved these changes
Oct 2, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 2, 2024
* feat: validate workspace when find objects Signed-off-by: SuZhou-Joe <[email protected]> * Changeset file for PR #8268 created/updated * fix: type error Signed-off-by: SuZhou-Joe <[email protected]> * feat: add unit test Signed-off-by: SuZhou-Joe <[email protected]> * feat: address some comments Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize performance Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit b6eb1a0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Hailong-am
pushed a commit
that referenced
this pull request
Oct 2, 2024
* feat: validate workspace when find objects * Changeset file for PR #8268 created/updated * fix: type error * feat: add unit test * feat: address some comments * feat: optimize performance --------- (cherry picked from commit b6eb1a0) Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Oct 3, 2024
…ject#8268) (opensearch-project#8431) * feat: validate workspace when find objects * Changeset file for PR opensearch-project#8268 created/updated * fix: type error * feat: add unit test * feat: address some comments * feat: optimize performance --------- (cherry picked from commit b6eb1a0) Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to validate the workspace ids users pass, if it is not valid, we should just throw a 400 error and save the resource of our search engine.
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration