-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace]Fix workspace assets page UI bugs #8265
base: main
Are you sure you want to change the base?
[Workspace]Fix workspace assets page UI bugs #8265
Conversation
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8265 +/- ##
=======================================
Coverage 64.09% 64.09%
=======================================
Files 3744 3744
Lines 88822 88822
Branches 13841 13842 +1
=======================================
+ Hits 56931 56932 +1
Misses 31277 31277
+ Partials 614 613 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
label: i18n.translate( | ||
'savedObjectsManagement.objectsTable.header.exportAssetsButtonLabel', | ||
{ | ||
defaultMessage: 'Export all assets', | ||
} | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to check new home page flag for all those wording change?
Description
This PR is for fixing a bunch of UI bugs in the workspace assets page. Here are the fixed list:
Issues Resolved
Screenshot
Global assets
Workspace assets
Testing the changes
yarn osd bootstrap --single-version ignore
config/opensearch_dashboards.yml
yarn start --no-base-path
Changelog
Check List
yarn test:jest
yarn test:jest_integration