[Backport 2.17] [Auto Suggest] PPL autocomplete fixes #8260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* add stats agg functions and insert snippet rules Signed-off-by: Paul Sebastian <[email protected]> * allow table suggestions with table name Signed-off-by: Paul Sebastian <[email protected]> * stop suggestion search from filter Signed-off-by: Paul Sebastian <[email protected]> * keep user hint height and pos constant Signed-off-by: Paul Sebastian <[email protected]> * fix issue where identifiers would suggest twice, after WS Signed-off-by: Paul Sebastian <[email protected]> * add some priority based tokens to appear at the top Signed-off-by: Paul Sebastian <[email protected]> * reenable plus and minus for sort command Signed-off-by: Paul Sebastian <[email protected]> * Changeset file for PR #8087 created/updated * update user hints Signed-off-by: Paul Sebastian <[email protected]> * update types Signed-off-by: Paul Sebastian <[email protected]> --------- Signed-off-by: Paul Sebastian <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 8118024) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
added
discover
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli and
joshuali925
as code owners
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.17 #8260 +/- ##
==========================================
+ Coverage 64.00% 64.13% +0.13%
==========================================
Files 3738 3739 +1
Lines 88796 88614 -182
Branches 13815 13791 -24
==========================================
+ Hits 56832 56833 +1
+ Misses 31367 31184 -183
Partials 597 597
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kavilla
approved these changes
Sep 20, 2024
abbyhu2000
approved these changes
Sep 21, 2024
sejli
approved these changes
Sep 21, 2024
abbyhu2000
added a commit
to abbyhu2000/OpenSearch-Dashboards
that referenced
this pull request
Sep 24, 2024
… (opensearch-project#8260)" This reverts commit d21c4d9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 8118024 from #8087.