Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(usage_collection): expose a function to mock plugin start #8235

Merged
merged 1 commit into from
Sep 24, 2024
Merged

test(usage_collection): expose a function to mock plugin start #8235

merged 1 commit into from
Sep 24, 2024

Conversation

ruanyl
Copy link
Member

@ruanyl ruanyl commented Sep 19, 2024

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@github-actions github-actions bot added all-star-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Sep 19, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 64.05%. Comparing base (636f399) to head (03613cf).
Report is 198 commits behind head on main.

Files with missing lines Patch % Lines
src/plugins/usage_collection/public/mocks.ts 33.33% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8235   +/-   ##
=======================================
  Coverage   64.05%   64.05%           
=======================================
  Files        3741     3741           
  Lines       88683    88686    +3     
  Branches    13817    13817           
=======================================
+ Hits        56809    56811    +2     
- Misses      31262    31263    +1     
  Partials      612      612
Flag Coverage Δ
Linux_1 30.05% <33.33%> (+<0.01%) ⬆️
Linux_2 58.85% <ø> (ø)
Linux_3 40.34% <33.33%> (?)
Linux_4 31.43% <ø> (ø)
Windows_1 30.06% <33.33%> (+<0.01%) ⬆️
Windows_2 58.80% <ø> (ø)
Windows_3 40.28% <33.33%> (-0.07%) ⬇️
Windows_4 31.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanyl ruanyl merged commit 9fd0f0b into opensearch-project:main Sep 24, 2024
70 of 71 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 24, 2024
@github-actions
test(usage_collection): expose a function to mock plugin start (#8235)
3196e1f 
Signed-off-by: Yulong Ruan <[email protected]>
(cherry picked from commit 9fd0f0b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 24, 2024
Merged
virajsanghvi pushed a commit to virajsanghvi/OpenSearch-Dashboards that referenced this pull request Sep 24, 2024
@ruanyl @virajsanghvi
test(usage_collection): expose a function to mock plugin start (opens…
89a0776 
…earch-project#8235)

Signed-off-by: Yulong Ruan <[email protected]>
SuZhou-Joe pushed a commit that referenced this pull request Sep 25, 2024
@opensearch-trigger-bot @github-actions
test(usage_collection): expose a function to mock plugin start (#8235) (
a2bfd94 
#8314)

(cherry picked from commit 9fd0f0b)

Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
yubonluo pushed a commit to yubonluo/OpenSearch-Dashboards that referenced this pull request Sep 25, 2024
@opensearch-trigger-bot @github-actions @yubonluo
test(usage_collection): expose a function to mock plugin start (opens…
a4a283c 
…earch-project#8235) (opensearch-project#8314)

(cherry picked from commit 9fd0f0b)

Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
yubonluo added a commit to yubonluo/OpenSearch-Dashboards that referenced this pull request Sep 25, 2024
@yubonluo
Revert "test(usage_collection): expose a function to mock plugin start (
77f8955 
opensearch-project#8235) (opensearch-project#8314)"

This reverts commit a4a283c.
@ananzh ananzh added the v2.18.0 label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhongnansu zhongnansu zhongnansu approved these changes

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
all-star-contributor backport 2.x Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.18.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ruanyl @SuZhou-Joe @zhongnansu @ananzh