Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Legacy Discover Table as Default for Discover 2.0 Experience #8233

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

LDrago27
Copy link
Collaborator

@LDrago27 LDrago27 commented Sep 18, 2024

Description

This PR aims at accomplishing following things

  1. Remove the Enable the legacy Discover Table setting when we have the QueryEnhancement flag turned ON
  2. Set the legacy Discover Table as default when QueryEnhancement flag is turned ON irrespective of users preference of Enable the legacy Discover toggle
  3. When QueryEnhancement flag is turned OFF respect users preference of Enable the legacy Discover toggle while displaying the discover table

Issues Resolved

Screenshot

Meeting.Recording.-.Sahoo.Suchit.Instant.Meeting.7.mp4

Testing the changes

  • Follow the steps shown in the above video to validate various scenarios listed above

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@github-actions github-actions bot added all-star-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 64.05%. Comparing base (6ebc1e3) to head (9c0010c).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...plication/components/data_grid/data_grid_table.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8233      +/-   ##
==========================================
- Coverage   64.05%   64.05%   -0.01%     
==========================================
  Files        3741     3741              
  Lines       88682    88683       +1     
  Branches    13817    13817              
==========================================
  Hits        56809    56809              
- Misses      31261    31262       +1     
  Partials      612      612              
Flag Coverage Δ
Linux_1 30.05% <0.00%> (-0.01%) ⬇️
Linux_2 58.85% <ø> (ø)
Linux_3 40.34% <0.00%> (-0.01%) ⬇️
Linux_4 31.43% <ø> (ø)
Windows_1 30.06% <0.00%> (-0.01%) ⬇️
Windows_2 58.80% <ø> (ø)
Windows_3 40.34% <0.00%> (-0.01%) ⬇️
Windows_4 31.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ashwin-pc
ashwin-pc previously approved these changes Sep 19, 2024
@ashwin-pc
Copy link
Member

ashwin-pc commented Sep 19, 2024

Actually i think we should remove this toggle all together in the new discover and always use the legacy table in Discover 2.0. Since we plan on revisiting the table differently in Discover 2.0, there should be no reason to show this switch until we are ready to implement that table.

Expected behaviour:

  • On switchign to Discover 2.0 always show the legacy table
  • on switching to the old Discover, show the table variant that the user had selected

@ashwin-pc ashwin-pc dismissed their stale review September 19, 2024 09:08

We dont need this toggle in Discover 2.0

@LDrago27 LDrago27 changed the title Display Enable Legacy Discover toggle button when SQL in selected Ser Legacy Discover Table as Default for Discover 2.0 Experience Sep 19, 2024
@LDrago27
Copy link
Collaborator Author

Actually i think we should remove this toggle all together in the new discover and always use the legacy table in Discover 2.0. Since we plan on revisiting the table differently in Discover 2.0, there should be no reason to show this switch until we are ready to implement that table.

Expected behaviour:

  • On switchign to Discover 2.0 always show the legacy table
  • on switching to the old Discover, show the table variant that the user had selected

@ashwin-pc Updated the PR and description as per the new requirements

Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@LDrago27 LDrago27 changed the title Ser Legacy Discover Table as Default for Discover 2.0 Experience Set Legacy Discover Table as Default for Discover 2.0 Experience Sep 19, 2024
@LDrago27 LDrago27 merged commit c7c16c9 into opensearch-project:main Sep 20, 2024
71 of 72 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 20, 2024
Signed-off-by: Suchit Sahoo <[email protected]>
(cherry picked from commit c7c16c9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LDrago27 pushed a commit that referenced this pull request Sep 20, 2024
(cherry picked from commit c7c16c9)

Signed-off-by: Suchit Sahoo <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
virajsanghvi pushed a commit to virajsanghvi/OpenSearch-Dashboards that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
all-star-contributor backport 2.x discover for discover reinvent Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants