-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Legacy Discover Table as Default for Discover 2.0 Experience #8233
Set Legacy Discover Table as Default for Discover 2.0 Experience #8233
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8233 +/- ##
==========================================
- Coverage 64.05% 64.05% -0.01%
==========================================
Files 3741 3741
Lines 88682 88683 +1
Branches 13817 13817
==========================================
Hits 56809 56809
- Misses 31261 31262 +1
Partials 612 612
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Actually i think we should remove this toggle all together in the new discover and always use the legacy table in Discover 2.0. Since we plan on revisiting the table differently in Discover 2.0, there should be no reason to show this switch until we are ready to implement that table. Expected behaviour:
|
We dont need this toggle in Discover 2.0
98f30eb
to
ada0e6f
Compare
Signed-off-by: Suchit Sahoo <[email protected]>
ada0e6f
to
9c0010c
Compare
@ashwin-pc Updated the PR and description as per the new requirements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Signed-off-by: Suchit Sahoo <[email protected]> (cherry picked from commit c7c16c9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit c7c16c9) Signed-off-by: Suchit Sahoo <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Suchit Sahoo <[email protected]>
Description
This PR aims at accomplishing following things
Issues Resolved
Screenshot
Meeting.Recording.-.Sahoo.Suchit.Instant.Meeting.7.mp4
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration