Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change page title of application headers to h1 and xs #8227

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Change page title of application headers to h1 and xs #8227

merged 2 commits into from
Sep 25, 2024

Conversation

AMoo-Miki
Copy link
Collaborator

Description

Change page title of application headers to h1 and xs

Screenshot

Before

v7

ov7

vNext

ov8

v9

ov9

After

v7

hv7

vNext

hv8

v9

hv9

Changelog

  • feat: Adjust semantics and sizing of page titles in application headers

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@codecov Codecov
Copy link

codecov bot commented Sep 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.05%. Comparing base (cc5531b) to head (62a1ecb).
Report is 79 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8227      +/-   ##
==========================================
- Coverage   64.05%   64.05%   -0.01%     
==========================================
  Files        3741     3741              
  Lines       88635    88635              
  Branches    13804    13804              
==========================================
- Hits        56776    56775       -1     
- Misses      31261    31262       +1     
  Partials      598      598
Flag Coverage Δ
Linux_1 30.07% <ø> (ø)
Linux_2 58.83% <ø> (ø)
Linux_3 40.37% <ø> (-0.01%) ⬇️
Linux_4 31.46% <ø> (ø)
Windows_1 30.08% <ø> (ø)
Windows_2 58.78% <ø> (ø)
Windows_3 40.37% <ø> (ø)
Windows_4 31.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

virajsanghvi
virajsanghvi approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@virajsanghvi virajsanghvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing check looks unrelated

@AMoo-Miki AMoo-Miki merged commit 7ab0980 into opensearch-project:main Sep 25, 2024
73 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 25, 2024
@github-actions @opensearch-changeset-bot
Change page title of application headers to h1 and xs (#8227)
4d1882b 
* Change page title of application headers to h1 and xs

Signed-off-by: Miki <[email protected]>

* Changeset file for PR #8227 created/updated

---------

Signed-off-by: Miki <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 7ab0980)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 25, 2024
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 25, 2024
@github-actions @opensearch-changeset-bot
Change page title of application headers to h1 and xs (#8227)
fd2bf3c 
* Change page title of application headers to h1 and xs

Signed-off-by: Miki <[email protected]>

* Changeset file for PR #8227 created/updated

---------

Signed-off-by: Miki <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 7ab0980)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 25, 2024
Closed
@abbyhu2000 abbyhu2000 added v2.18.0 and removed 2.17.1 labels Sep 25, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 26, 2024
@github-actions @opensearch-changeset-bot
Change page title of application headers to h1 and xs (#8227)
9394f97 
* Change page title of application headers to h1 and xs

Signed-off-by: Miki <[email protected]>

* Changeset file for PR #8227 created/updated

---------

Signed-off-by: Miki <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 7ab0980)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 26, 2024
Closed
@virajsanghvi virajsanghvi added the look & feel Look and Feel Improvements label Sep 26, 2024
AMoo-Miki pushed a commit that referenced this pull request Sep 26, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
Change page title of application headers to h1 and xs (#8227) (#8341)
0fe22af 
* Change page title of application headers to h1 and xs



* Changeset file for PR #8227 created/updated

---------



(cherry picked from commit 7ab0980)

Signed-off-by: Miki <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 26, 2024
@github-actions @opensearch-changeset-bot
Change page title of application headers to h1 and xs (#8227) (#8341)
623b8ce 
* Change page title of application headers to h1 and xs

* Changeset file for PR #8227 created/updated

---------

(cherry picked from commit 7ab0980)

Signed-off-by: Miki <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 0fe22af)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Oct 3, 2024
@opensearch-trigger-bot @github-actions
@opensearch-changeset-bot @SuZhou-Joe
Change page title of application headers to h1 and xs (opensearch-pro…
b5ef879 
…ject#8227) (opensearch-project#8341)

* Change page title of application headers to h1 and xs



* Changeset file for PR opensearch-project#8227 created/updated

---------



(cherry picked from commit 7ab0980)

Signed-off-by: Miki <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavilla kavilla kavilla approved these changes

@virajsanghvi virajsanghvi virajsanghvi approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.17-next backport 2.17 distinguished-contributor in-next look & feel Look and Feel Improvements v2.18.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AMoo-Miki @virajsanghvi @kavilla @SuZhou-Joe @abbyhu2000