-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[workspace]Fix/the UI of workspace list table #8219
base: main
Are you sure you want to change the base?
[workspace]Fix/the UI of workspace list table #8219
Conversation
2e696d6
to
806654f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8219 +/- ##
==========================================
+ Coverage 60.75% 60.77% +0.01%
==========================================
Files 3798 3798
Lines 90690 90689 -1
Branches 14277 14277
==========================================
+ Hits 55101 55113 +12
+ Misses 32090 32076 -14
- Partials 3499 3500 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
92c2b34
to
4886299
Compare
c378907
to
0f61a69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see there is a conflict now, you may need to address :)
return isDashboardAdmin ? ( | ||
<> | ||
<EuiButton color="danger" iconType="trash" onClick={onClick}> | ||
Delete {selection.length} {selection.length > 1 ? 'workspaces' : 'workspace'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add i18n for the text, take this as example:
<FormattedMessage
id="dataSourcesManagement.dataSourcesTable.dissociateSelectedDataSources"
defaultMessage="{selectionSize, plural, one {Remove # association} other {Remove # associations}}"
values={{ selectionSize: selectedDataSources.length }}
/>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your comments, already updated.
0f61a69
to
9bf0be9
Compare
{i18n.translate('workspace.list.page.delete.button.info', { | ||
defaultMessage: 'Delete {num} workspace{pluralSuffix, select, true {} other {s}}', | ||
values: { | ||
num: selection.length, | ||
pluralSuffix: selection.length === 1, | ||
}, | ||
})} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{i18n.translate('workspace.list.page.delete.button.info', { | |
defaultMessage: 'Delete {num} workspace{pluralSuffix, select, true {} other {s}}', | |
values: { | |
num: selection.length, | |
pluralSuffix: selection.length === 1, | |
}, | |
})} | |
{i18n.translate('workspace.list.page.delete.button.info', { | |
defaultMessage: | |
'{selectedCount, plural, one {Delete # workspace} other {Delete # workspaces}}', | |
values: { | |
selectedCount: selection.length, | |
}, | |
})} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you! already updated.
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
7176e0f
to
f52af39
Compare
Description
This pr fixes the style of workspace list table(addressing issues 217-227, and 232-233) by:
Screenshot
Changelog
Check List
yarn test:jest
yarn test:jest_integration