Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add loading indicator and counter to query result #8212

Merged
merged 5 commits into from
Sep 20, 2024
Merged

Add loading indicator and counter to query result #8212

merged 5 commits into from
Sep 20, 2024
+252 −13

Conversation

abbyhu2000
Copy link
Member

@abbyhu2000 abbyhu2000 commented Sep 17, 2024 •
edited
Loading

Description

  • when a query takes longer than 3s to complete, a loading indicator will appear after 3s and will also show a time counter; the completion time will show in seconds.
  • when a query takes less than 1s to complete, the completion time will be shown in miliseconds.

Issues Resolved

Screenshot

Screen.Recording.2024-09-17.at.2.58.10.PM.mov

Testing the changes

Changelog

  • feat: Add loading indicator and counter to query result

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@abbyhu2000 abbyhu2000 added the discover for discover reinvent label Sep 17, 2024
opensearch-changeset-bot bot added a commit to abbyhu2000/OpenSearch-Dashboards that referenced this pull request Sep 17, 2024
@opensearch-changeset-bot
Changeset file for PR opensearch-project#8212 created/updated
b1b6e6e
abbyhu2000 pushed a commit to abbyhu2000/OpenSearch-Dashboards that referenced this pull request Sep 17, 2024
@opensearch-changeset-bot @abbyhu2000
Changeset file for PR opensearch-project#8212 created/updated
2fb3d5a
@codecov Codecov
Copy link

codecov bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 64.06%. Comparing base (cea972f) to head (fec2623).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...query_string/language_service/lib/query_result.tsx 70.00% 6 Missing ⚠️
...ic/application/view_components/utils/use_search.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8212   +/-   ##
=======================================
  Coverage   64.05%   64.06%           
=======================================
  Files        3741     3741           
  Lines       88682    88702   +20     
  Branches    13817    13822    +5     
=======================================
+ Hits        56809    56829   +20     
  Misses      31261    31261           
  Partials      612      612
Flag Coverage Δ
Linux_1 30.04% <4.76%> (-0.01%) ⬇️
Linux_2 58.85% <ø> (ø)
Linux_3 40.36% <66.66%> (+0.02%) ⬆️
Linux_4 31.42% <5.00%> (-0.01%) ⬇️
Windows_1 30.05% <4.76%> (-0.01%) ⬇️
Windows_2 58.80% <ø> (ø)
Windows_3 40.36% <66.66%> (+0.02%) ⬆️
Windows_4 31.42% <5.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AMoo-Miki
AMoo-Miki reviewed Sep 19, 2024
View reviewed changes
yarn.lock Outdated Show resolved Hide resolved
@abbyhu2000 abbyhu2000 force-pushed the loading_query_result branch 3 times, most recently from 687d610 to ba73d87 Compare September 19, 2024 22:48
@abbyhu2000
address comments
5cd91f5 
Signed-off-by: abbyhu2000 <[email protected]>
@abbyhu2000
update snapshot
fec2623 
Signed-off-by: abbyhu2000 <[email protected]>
ashwin-pc
ashwin-pc approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

src/plugins/data/public/query/query_string/language_service/lib/query_result.tsx
const getTime = () => {
const time = new Date().getTime() - props.queryStatus.startTime!;
if (time > BUFFER_TIME) {
setElapsedTime(time);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its rounded down to seconds so that should not be a problem. Take a look at the video attached Miki :)

@abbyhu2000
Copy link
Member Author

Link checker failure not related:

* [404] [http://sites.google.com/site/murmurhash/](http://sites.google.com/site/murmurhash/) | Failed: Network error: Not Found

@abbyhu2000 abbyhu2000 merged commit 27ba36c into opensearch-project:main Sep 20, 2024
66 of 67 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 20, 2024
@github-actions @opensearch-changeset-bot
Add loading indicator and counter to query result (#8212)
d9373d8 
* add loading indicator and counter to query result

Signed-off-by: abbyhu2000 <[email protected]>

* Changeset file for PR #8212 created/updated

* add unit tests

Signed-off-by: abbyhu2000 <[email protected]>

* address comments

Signed-off-by: abbyhu2000 <[email protected]>

* update snapshot

Signed-off-by: abbyhu2000 <[email protected]>

---------

Signed-off-by: abbyhu2000 <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 27ba36c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 20, 2024
@github-actions @opensearch-changeset-bot
Add loading indicator and counter to query result (#8212)
e69c5cb 
* add loading indicator and counter to query result

Signed-off-by: abbyhu2000 <[email protected]>

* Changeset file for PR #8212 created/updated

* add unit tests

Signed-off-by: abbyhu2000 <[email protected]>

* address comments

Signed-off-by: abbyhu2000 <[email protected]>

* update snapshot

Signed-off-by: abbyhu2000 <[email protected]>

---------

Signed-off-by: abbyhu2000 <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 27ba36c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Sep 20, 2024
Merged
Merged
abbyhu2000 pushed a commit that referenced this pull request Sep 20, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
Add loading indicator and counter to query result (#8212) (#8272)
7198420 
* add loading indicator and counter to query result



* Changeset file for PR #8212 created/updated

* add unit tests



* address comments



* update snapshot



---------



(cherry picked from commit 27ba36c)

Signed-off-by: abbyhu2000 <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
abbyhu2000 pushed a commit that referenced this pull request Sep 20, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
Add loading indicator and counter to query result (#8212) (#8273)
aa42f67 
* add loading indicator and counter to query result



* Changeset file for PR #8212 created/updated

* add unit tests



* address comments



* update snapshot



---------



(cherry picked from commit 27ba36c)

Signed-off-by: abbyhu2000 <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
amsiglan pushed a commit to amsiglan/OpenSearch-Dashboards that referenced this pull request Sep 20, 2024
@abbyhu2000 @opensearch-changeset-bot @amsiglan
Add loading indicator and counter to query result (opensearch-project…
8a907ec 
…#8212)

* add loading indicator and counter to query result

Signed-off-by: abbyhu2000 <[email protected]>

* Changeset file for PR opensearch-project#8212 created/updated

* add unit tests

Signed-off-by: abbyhu2000 <[email protected]>

* address comments

Signed-off-by: abbyhu2000 <[email protected]>

* update snapshot

Signed-off-by: abbyhu2000 <[email protected]>

---------

Signed-off-by: abbyhu2000 <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AMoo-Miki AMoo-Miki AMoo-Miki left review comments

@sejli sejli sejli left review comments

@ashwin-pc ashwin-pc ashwin-pc approved these changes

@LDrago27 LDrago27 LDrago27 approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
2.17.1 backport 2.x backport 2.17 discover for discover reinvent distinguished-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@abbyhu2000 @AMoo-Miki @ashwin-pc @LDrago27 @sejli