[Workspace] Integrate dashboard admin with dynamic config #8137
+65
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yubonluo
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
opensearch-changeset-bot bot
added a commit
to yubonluo/OpenSearch-Dashboards
that referenced
this pull request
Sep 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8137 +/- ##
=======================================
Coverage 60.86% 60.86%
=======================================
Files 3793 3793
Lines 90442 90457 +15
Branches 14198 14202 +4
=======================================
+ Hits 55045 55056 +11
- Misses 31910 31911 +1
- Partials 3487 3490 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yubonluo
force-pushed
the
2.17/Integrate-dashboard-admin-with-dynamic-config
branch
from
57c7e9e
to
9640545
Compare
Signed-off-by: yubonluo <[email protected]>
yubonluo
force-pushed
the
2.17/Integrate-dashboard-admin-with-dynamic-config
branch
from
9640545
to
f1e6c5b
Compare
SuZhou-Joe
approved these changes
Oct 23, 2024
ruanyl
approved these changes
Oct 29, 2024
raintygao
approved these changes
Oct 29, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 11, 2024
Signed-off-by: yubonluo <[email protected]> (cherry picked from commit bdb2953) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Nov 12, 2024
(cherry picked from commit bdb2953) Signed-off-by: yubonluo <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrate dashboard admin with dynamic config(#7194)
If you do not config users/groups, anyone will not be dashboard admin.
If your backend role is admin, you will be dashboard admin.
If your login is admin, you will be dashboard admin.
If you do not config users as *, anyone will be dashboard admin.
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration