Use smaller and compressed varients of buttons and form components (#7304) #7417

AMoo-Miki · 2024-07-23T22:25:06Z

cherry picked 6f28170 from #7304

Changelog

skip

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

…pensearch-project#7304) * Bump OUI Signed-off-by: Miki <[email protected]> * Use EuiSmallButton Signed-off-by: Miki <[email protected]> * Use EuiSmallButtonIcon Signed-off-by: Miki <[email protected]> * Use EuiSmallButtonEmpty Signed-off-by: Miki <[email protected]> * Use EuiCompressedFormRow Signed-off-by: Miki <[email protected]> * Use EuiCompressedField* Signed-off-by: Miki <[email protected]> * Use EuiCompressedSelect and EuiCompressedSuperSelect Signed-off-by: Miki <[email protected]> * Use EuiCompressedCheckbox and EuiCompressedCheckboxGroup Signed-off-by: Miki <[email protected]> * Use EuiCompressedFilePicker Signed-off-by: Miki <[email protected]> * Use EuiCompressedRadio and EuiCompressedRadioGroup Signed-off-by: Miki <[email protected]> * Use EuiCompressedSwitch Signed-off-by: Miki <[email protected]> * Use EuiCompressedEuiTextArea Signed-off-by: Miki <[email protected]> * Use EuiCompressedComboBox Signed-off-by: Miki <[email protected]> * Use compressed ValidatedDualRange Signed-off-by: Miki <[email protected]> * Use EuiSmallFilterButton Signed-off-by: Miki <[email protected]> * Undo unnecessary EuiSmallButton* uses Signed-off-by: Miki <[email protected]> * Revisit size and density changes in workspaces Signed-off-by: Miki <[email protected]> * Fix unit tests Signed-off-by: Miki <[email protected]> --------- Signed-off-by: Miki <[email protected]> (cherry picked from commit 6f28170) Signed-off-by: Miki <[email protected]>

codecov · 2024-07-23T22:39:42Z

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 67.70%. Comparing base (06469bd) to head (3546f48).

Files	Patch %	Lines
...lic/ui/shard_failure_modal/shard_failure_modal.tsx	0.00%	2 Missing ⚠️
...c/core/public/notifications/toasts/error_toast.tsx	0.00%	1 Missing ⚠️
...cation/components/something_went_wrong_callout.tsx	0.00%	1 Missing ⚠️
...ry_management/saved_query_management_component.tsx	0.00%	1 Missing ⚠️
..._actions/customize_title/customize_panel_modal.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##              2.x    #7417   +/-   ##
=======================================
  Coverage   67.70%   67.70%           
=======================================
  Files        3584     3584           
  Lines       72248    72248           
  Branches    11819    11819           
=======================================
  Hits        48917    48917           
  Misses      20359    20359           
  Partials     2972     2972

Flag	Coverage Δ
Linux_1	`33.18% <14.28%> (ø)`
Linux_2	`55.66% <0.00%> (ø)`
Linux_3	`44.46% <40.00%> (+<0.01%)`	⬆️
Linux_4	`34.19% <60.00%> (ø)`
Windows_1	`33.20% <14.28%> (ø)`
Windows_2	`55.61% <0.00%> (ø)`
Windows_3	`44.47% <40.00%> (ø)`
Windows_4	`34.19% <60.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

virajsanghvi · 2024-07-23T23:22:52Z

test/functional/apps/dashboard/dashboard_saved_query.js

@@ -58,7 +58,7 @@ export default function ({ getService, getPageObjects }) {
        await savedQueryManagementComponent.openSavedQueryManagementComponent();
        const descriptionText = await testSubjects.getVisibleText('saved-query-management-popover');
        expect(descriptionText).to.eql(
-          'SAVED QUERIES\nThere are no saved queries. Save query text and filters that you want to use again.\nSave current query'
+          'Saved Queries\nThere are no saved queries. Save query text and filters that you want to use again.\nSave current query'


Intentional change?

This is the side effect of opensearch-project/oui#1283

virajsanghvi · 2024-07-23T23:23:47Z

Approved assuming unrelated failing checks

opensearch-trigger-bot · 2024-07-23T23:44:20Z

The backport to 2.16 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.16 2.16
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.16
# Create a new branch
git switch --create backport/backport-7417-to-2.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 77f6c7074352f6cb007e5c56aef2057dec9e21da
# Push it to GitHub
git push --set-upstream origin backport/backport-7417-to-2.16
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.16

Then, create a pull request where the base branch is 2.16 and the compare/head branch is backport/backport-7417-to-2.16.

yubonluo · 2024-07-24T05:52:32Z

Hi @AMoo-Miki, when will this pr back port to 2.16?

opensearch-trigger-bot · 2024-07-24T21:42:02Z

The backport to 2.16 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.16 2.16
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.16
# Create a new branch
git switch --create backport/backport-7417-to-2.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 77f6c7074352f6cb007e5c56aef2057dec9e21da
# Push it to GitHub
git push --set-upstream origin backport/backport-7417-to-2.16
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.16

Then, create a pull request where the base branch is 2.16 and the compare/head branch is backport/backport-7417-to-2.16.

…pensearch-project#7304) (opensearch-project#7417) * Bump OUI * Use EuiSmallButton * Use EuiSmallButtonIcon * Use EuiSmallButtonEmpty * Use EuiCompressedFormRow * Use EuiCompressedField* * Use EuiCompressedSelect and EuiCompressedSuperSelect * Use EuiCompressedCheckbox and EuiCompressedCheckboxGroup * Use EuiCompressedFilePicker * Use EuiCompressedRadio and EuiCompressedRadioGroup * Use EuiCompressedSwitch * Use EuiCompressedEuiTextArea * Use EuiCompressedComboBox * Use compressed ValidatedDualRange * Use EuiSmallFilterButton * Undo unnecessary EuiSmallButton* uses * Revisit size and density changes in workspaces * Fix unit tests --------- (cherry picked from commit 6f28170) Signed-off-by: Miki <[email protected]>

AMoo-Miki requested review from ananzh, kavilla, ashwin-pc, joshuarrrr, abbyhu2000, zengyan-amazon, zhongnansu, manasvinibs, ZilongX, Flyingliuhub, curq, bandinib-amzn, SuZhou-Joe, ruanyl, BionIT, xinruiba, zhyuanqi, mengweieric, LDrago27 and virajsanghvi as code owners July 23, 2024 22:25

github-actions bot added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Jul 23, 2024

AMoo-Miki added v2.16.0 backport 2.16 look & feel Look and Feel Improvements labels Jul 23, 2024

virajsanghvi approved these changes Jul 23, 2024

View reviewed changes

LDrago27 approved these changes Jul 23, 2024

View reviewed changes

AMoo-Miki merged commit 77f6c70 into opensearch-project:2.x Jul 23, 2024
67 of 69 checks passed

opensearch-trigger-bot bot added the failed backport label Jul 23, 2024

kavilla added backport 2.16 and removed backport 2.16 labels Jul 24, 2024

ananzh mentioned this pull request Jul 24, 2024

Missing backports from current 2.x to 2.16 #7466

Closed

7 tasks

AMoo-Miki removed the failed backport label Aug 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use smaller and compressed varients of buttons and form components (#7304) #7417

Use smaller and compressed varients of buttons and form components (#7304) #7417

AMoo-Miki commented Jul 23, 2024

codecov bot commented Jul 23, 2024 •

edited

Loading

virajsanghvi Jul 23, 2024

AMoo-Miki Jul 23, 2024

virajsanghvi commented Jul 23, 2024

opensearch-trigger-bot bot commented Jul 23, 2024

yubonluo commented Jul 24, 2024

opensearch-trigger-bot bot commented Jul 24, 2024

Use smaller and compressed varients of buttons and form components (#7304) #7417

Use smaller and compressed varients of buttons and form components (#7304) #7417

Conversation

AMoo-Miki commented Jul 23, 2024

Changelog

Check List

codecov bot commented Jul 23, 2024 • edited Loading

Codecov Report

virajsanghvi Jul 23, 2024

Choose a reason for hiding this comment

AMoo-Miki Jul 23, 2024

Choose a reason for hiding this comment

virajsanghvi commented Jul 23, 2024

opensearch-trigger-bot bot commented Jul 23, 2024

yubonluo commented Jul 24, 2024

opensearch-trigger-bot bot commented Jul 24, 2024

codecov bot commented Jul 23, 2024 •

edited

Loading