Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Dataset navigator #7348

Closed
wants to merge 1 commit into from

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Jul 21, 2024

Description

Modifications onto the data set navigator from @sejli .

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

Attention: Patch coverage is 25.58140% with 32 lines in your changes missing coverage. Please review.

Project coverage is 67.67%. Comparing base (e64de15) to head (fcfddfa).

Files Patch % Lines
.../data/public/ui/dataset_navigator/fetch_indices.ts 11.11% 8 Missing ⚠️
src/plugins/data/public/ui/ui_service.ts 0.00% 5 Missing ⚠️
.../data_explorer/public/components/sidebar/index.tsx 33.33% 4 Missing ⚠️
src/plugins/data/public/ui/settings/settings.ts 0.00% 3 Missing ⚠️
.../data/common/search/search_source/search_source.ts 0.00% 2 Missing ⚠️
.../ui/dataset_navigator/create_dataset_navigator.tsx 0.00% 2 Missing ⚠️
...a/public/ui/dataset_navigator/fetch_datasources.ts 33.33% 2 Missing ⚠️
...ublic/ui/dataset_navigator/fetch_index_patterns.ts 33.33% 2 Missing ⚠️
...ns/data/public/ui/search_bar/create_search_bar.tsx 0.00% 2 Missing ⚠️
...plugins/data/public/ui/dataset_navigator/index.tsx 75.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7348      +/-   ##
==========================================
- Coverage   67.70%   67.67%   -0.03%     
==========================================
  Files        3520     3523       +3     
  Lines       69700    69690      -10     
  Branches    11376    11372       -4     
==========================================
- Hits        47189    47165      -24     
- Misses      19716    19728      +12     
- Partials     2795     2797       +2     
Flag Coverage Δ
Linux_1 33.18% <18.18%> (-0.01%) ⬇️
Linux_2 55.46% <0.00%> (-0.01%) ⬇️
Linux_3 43.29% <21.95%> (-0.02%) ⬇️
Linux_4 ?
Windows_1 33.20% <18.18%> (-0.01%) ⬇️
Windows_2 55.41% <0.00%> (-0.01%) ⬇️
Windows_3 43.31% <21.95%> (-0.01%) ⬇️
Windows_4 34.67% <22.85%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kawika Avilla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant