Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: data source selector in dev tools tab moved to left #7347

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

ruanyl
Copy link
Member

@ruanyl ruanyl commented Jul 21, 2024

Description

The issue was introduced by 4c61906

Before:
image

After:
image

Issues Resolved

#7349

Screenshot

Testing the changes

Changelog

  • fix: data source selector in dev tools tab moved to left

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.71%. Comparing base (376ead0) to head (7807ccd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7347   +/-   ##
=======================================
  Coverage   67.71%   67.71%           
=======================================
  Files        3518     3518           
  Lines       69638    69638           
  Branches    11365    11365           
=======================================
  Hits        47153    47153           
- Misses      19694    19696    +2     
+ Partials     2791     2789    -2     
Flag Coverage Δ
Linux_1 33.16% <ø> (ø)
Linux_2 55.46% <ø> (ø)
Linux_3 43.31% <ø> (ø)
Linux_4 34.69% <ø> (ø)
Windows_1 33.18% <ø> (-0.03%) ⬇️
Windows_2 55.41% <ø> (?)
Windows_3 43.33% <ø> (ø)
Windows_4 34.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanyl ruanyl merged commit 9ce538a into opensearch-project:main Jul 22, 2024
68 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 22, 2024
* fix: style issue that data source selector in dev tools tab moved to left

Signed-off-by: Yulong Ruan <[email protected]>

* Changeset file for PR #7347 created/updated

---------

Signed-off-by: Yulong Ruan <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 9ce538a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Jul 22, 2024
* fix: style issue that data source selector in dev tools tab moved to left



* Changeset file for PR #7347 created/updated

---------



(cherry picked from commit 9ce538a)

Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants