Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Manual Backport][2.x][Data Source] Restrict to manage data source on the DSM UI #7303

Merged
merged 2 commits into from
Jul 18, 2024
Merged

[Manual Backport][2.x][Data Source] Restrict to manage data source on the DSM UI #7303

merged 2 commits into from
Jul 18, 2024

Conversation

yubonluo
Copy link
Contributor

Description

Manual backport #7214

delete conflict file:

  • src/plugins/data_source_management/public/components/data_source_home_panel/data_source_home_panel.tsx
  • src/plugins/data_source_management/public/components/data_source_home_panel/data_source_home_panel.test.tsx

Issues Resolved

Screenshot

Testing the changes

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@github-actions github-actions bot added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Jul 18, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.71%. Comparing base (bbab1ad) to head (be7a7e1).
Report is 2 commits behind head on 2.x.

Files Patch % Lines
...rce/components/edit_form/edit_data_source_form.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              2.x    #7303      +/-   ##
==========================================
- Coverage   67.73%   67.71%   -0.02%     
==========================================
  Files        3452     3450       -2     
  Lines       68315    68269      -46     
  Branches    11114    11106       -8     
==========================================
- Hits        46275    46231      -44     
+ Misses      19358    19354       -4     
- Partials     2682     2684       +2
Flag Coverage Δ
Linux_1 33.27% <ø> (-0.07%) ⬇️
Linux_2 55.42% <ø> (ø)
Linux_3 45.05% <85.71%> (+<0.01%) ⬆️
Windows_1 33.29% <ø> (-0.07%) ⬇️
Windows_2 55.37% <ø> (ø)
Windows_3 45.06% <85.71%> (+<0.01%) ⬆️
Windows_4 34.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ruanyl
ruanyl previously approved these changes Jul 18, 2024
View reviewed changes
SuZhou-Joe
SuZhou-Joe previously approved these changes Jul 18, 2024
View reviewed changes
@SuZhou-Joe
Copy link
Member

CI failed because of snapshot, we should fix that.

@yubonluo
fix unit test error
be7a7e1 
Signed-off-by: yubonluo <[email protected]>
@yubonluo
Copy link
Contributor Author

yubonluo commented Jul 18, 2024 •
edited
Loading

failed

fixed it.

@ruanyl ruanyl merged commit 1b8c801 into opensearch-project:2.x Jul 18, 2024
64 of 65 checks passed
yubonluo added a commit to yubonluo/OpenSearch-Dashboards that referenced this pull request Jul 23, 2024
@yubonluo
Revert [Manual Backport][2.x][Data Source] Restrict to manage data so…
4d11738 
…urce on the DSM UI (opensearch-project#7303)

Signed-off-by: yubonluo <[email protected]>
ruanyl pushed a commit that referenced this pull request Jul 23, 2024
@yubonluo
[Manual Backport][2.x][Data Source] Restrict to manage data source on…
14071ff 
… the DSM UI (#7395)

* Revert [Manual Backport][2.x][Data Source] Restrict to manage data source on the DSM UI (#7303)

Signed-off-by: yubonluo <[email protected]>

* [Manual Backport][2.x][Data Source] Restrict to manage data source on the DSM UI

Signed-off-by: yubonluo <[email protected]>

---------

Signed-off-by: yubonluo <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 23, 2024
@github-actions
[Manual Backport][2.x][Data Source] Restrict to manage data source on…
24a61f8 
… the DSM UI (#7395)

* Revert [Manual Backport][2.x][Data Source] Restrict to manage data source on the DSM UI (#7303)

Signed-off-by: yubonluo <[email protected]>

* [Manual Backport][2.x][Data Source] Restrict to manage data source on the DSM UI

Signed-off-by: yubonluo <[email protected]>

---------

Signed-off-by: yubonluo <[email protected]>
(cherry picked from commit 14071ff)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Jul 23, 2024
@opensearch-trigger-bot @github-actions
[Manual Backport][2.x][Data Source] Restrict to manage data source on…
f6c9bc0 
… the DSM UI (#7395) (#7398)

* Revert [Manual Backport][2.x][Data Source] Restrict to manage data source on the DSM UI (#7303)



* [Manual Backport][2.x][Data Source] Restrict to manage data source on the DSM UI



---------


(cherry picked from commit 14071ff)

Signed-off-by: yubonluo <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@ruanyl ruanyl ruanyl approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

Assignees
No one assigned
Labels
Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yubonluo @SuZhou-Joe @ruanyl