Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Add Drag & Drop Across Axis Functionality to Vis Builder #7266

Merged
merged 1 commit into from
Jul 22, 2024
Merged

[Backport 2.x] Add Drag & Drop Across Axis Functionality to Vis Builder #7266

merged 1 commit into from
Jul 22, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 27669cf from #7107.

@github-actions @opensearch-changeset-bot
Add Drag & Drop Across Axis Functionality to Vis Builder (#7107)
e8213fd 
* Add Drag Across Axis Functionality to Vis Builder

Signed-off-by: Suchit Sahoo <[email protected]>

* Changeset file for PR #7107 created/updated

---------

Signed-off-by: Suchit Sahoo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 27669cf)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot added vis builder autocut Skip the changelog verification check on backports valued-contributor labels Jul 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@codecov Codecov
Copy link

codecov bot commented Jul 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 10.55901% with 144 lines in your changes missing coverage. Please review.

Project coverage is 67.62%. Comparing base (68ae0d7) to head (e8213fd).
Report is 4 commits behind head on 2.x.

Files Patch % Lines
...r/public/application/components/data_tab/index.tsx 0.00% 39 Missing ⚠️
...ta_tab/drag_drop/replace_field_in_configuration.ts 0.00% 23 Missing ⚠️
...s/data_tab/drag_drop/move_field_between_schemas.ts 0.00% 18 Missing ⚠️
...mponents/data_tab/utils/get_valid_aggregations.tsx 21.73% 18 Missing ⚠️
...s/data_tab/drag_drop/add_field_to_configuration.ts 0.00% 13 Missing ⚠️
...data_tab/drag_drop/reorder_fields_within_schema.ts 0.00% 11 Missing ⚠️
...pplication/components/data_tab/use/use_dropbox.tsx 0.00% 11 Missing ⚠️
...public/application/components/data_tab/dropbox.tsx 0.00% 9 Missing ⚠️
...c/application/components/data_tab/config_panel.tsx 0.00% 1 Missing ⚠️
...lication/components/data_tab/schema_to_dropbox.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              2.x    #7266      +/-   ##
==========================================
- Coverage   67.72%   67.62%   -0.11%     
==========================================
  Files        3452     3458       +6     
  Lines       68284    68401     +117     
  Branches    11105    11135      +30     
==========================================
+ Hits        46248    46256       +8     
- Misses      19359    19469     +110     
+ Partials     2677     2676       -1
Flag Coverage Δ
Linux_1 33.22% <10.55%> (-0.07%) ⬇️
Linux_2 55.42% <ø> (ø)
Linux_3 45.05% <ø> (-0.01%) ⬇️
Linux_4 34.85% <ø> (ø)
Windows_1 33.24% <10.55%> (-0.07%) ⬇️
Windows_2 55.37% <ø> (ø)
Windows_3 45.06% <ø> (ø)
Windows_4 34.85% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LDrago27 LDrago27 merged commit b1e5237 into 2.x Jul 22, 2024
67 of 70 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 23, 2024
@github-actions @opensearch-changeset-bot
Add Drag & Drop Across Axis Functionality to Vis Builder (#7107) (#7266)
ca65208 
* Add Drag Across Axis Functionality to Vis Builder

* Changeset file for PR #7107 created/updated

---------

(cherry picked from commit 27669cf)

Signed-off-by: Suchit Sahoo <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit b1e5237)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 23, 2024
Merged
ananzh added a commit that referenced this pull request Jul 24, 2024
@opensearch-trigger-bot @github-actions
@opensearch-changeset-bot @ananzh
Add Drag & Drop Across Axis Functionality to Vis Builder (#7107) (#7266…
3505cca 
…) (#7416)

* Add Drag Across Axis Functionality to Vis Builder

* Changeset file for PR #7107 created/updated

---------

(cherry picked from commit 27669cf)





(cherry picked from commit b1e5237)

Signed-off-by: Suchit Sahoo <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Anan Zhuang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananzh ananzh ananzh approved these changes

@LDrago27 LDrago27 LDrago27 approved these changes

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

Assignees
No one assigned
Labels
autocut Skip the changelog verification check on backports backport 2.16 failed changeset v2.16.0 valued-contributor vis builder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LDrago27 @ananzh @ashwin-pc