-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[workspace] Fix not able to query legacy data when have at least 1 workspace #7254
Conversation
Signed-off-by: Hailong Cui <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7254 +/- ##
==========================================
+ Coverage 67.52% 67.53% +0.01%
==========================================
Files 3504 3504
Lines 69410 69412 +2
Branches 11324 11324
==========================================
+ Hits 46868 46877 +9
+ Misses 19779 19775 -4
+ Partials 2763 2760 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
this is should able to fix by #7252 |
src/plugins/saved_objects_management/server/routes/scroll_count.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
…rkspace (#7254) * Fix not able to query legacy data when have at least 1 workspace Signed-off-by: Hailong Cui <[email protected]> * fix typo Signed-off-by: Hailong Cui <[email protected]> * update snapshot Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> Co-authored-by: Yulong Ruan <[email protected]> (cherry picked from commit 3bb4170) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…rkspace (#7254) (#7320) * Fix not able to query legacy data when have at least 1 workspace * fix typo * update snapshot --------- (cherry picked from commit 3bb4170) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <[email protected]>
Description
Remove the workspace filter condition when user not in any workspace, the workspace query condition will automatically add when saved objects permission control is enabled.
If saved objects permission control is disabled, there is no need to filter by workspace when no workspace is selected, user should able to see all objects.
Issues Resolved
#7253
Screenshot
Screen.Recording.2024-07-17.at.11.40.35.mov
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration