[Workspace]Register workspace settings under setup and settings #7242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7242 +/- ##
==========================================
- Coverage 67.62% 67.61% -0.02%
==========================================
Files 3471 3471
Lines 68613 68615 +2
Branches 11165 11166 +1
==========================================
- Hits 46399 46391 -8
- Misses 19510 19520 +10
Partials 2704 2704
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
opensearch-changeset-bot bot
added a commit
to wanglam/OpenSearch-Dashboards
that referenced
this pull request
Jul 15, 2024
wanglam
force-pushed
the
feat-register-workspace-list-as-settings
branch
from
4c72641
to
ff3b73a
Compare
opensearch-changeset-bot bot
added a commit
to wanglam/OpenSearch-Dashboards
that referenced
this pull request
Jul 15, 2024
opensearch-changeset-bot bot
added a commit
to wanglam/OpenSearch-Dashboards
that referenced
this pull request
Jul 15, 2024
wanglam
changed the title
wanglam
force-pushed
the
feat-register-workspace-list-as-settings
branch
from
1c76921
to
c3dd768
Compare
Signed-off-by: Lin Wang <[email protected]>
wanglam
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub and
curq
as code owners
wanglam
requested review from
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27 and
virajsanghvi
as code owners
Hailong-am
approved these changes
Jul 16, 2024
| // nav link should be visible when nav group enabled | ||
| navLinkStatus: core.chrome.navGroup.getNavGroupEnabled() | ||
| ? AppNavLinkStatus.visible | ||
| : AppNavLinkStatus.hidden, |
There was a problem hiding this comment.
can we add a comment of when core.chrome.navGroup.getNavGroupEnabled() changed, the page will refresh and application setup will execute it again?
SuZhou-Joe
approved these changes
Jul 16, 2024
ruanyl
approved these changes
Jul 16, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
* Move workspace list under setup and settings nav group Signed-off-by: Lin Wang <[email protected]> * Changeset file for PR #7242 created/updated * Add comment for page refresh Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit dcd4cf6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Jul 16, 2024
… (#7258) * Move workspace list under setup and settings nav group * Changeset file for PR #7242 created/updated * Add comment for page refresh --------- (cherry picked from commit dcd4cf6) Signed-off-by: Lin Wang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for registering workspace settings under setup and settings. The workspace settings will link to the workspace list page. To support display link in the left navigation, need to update link status to visible when nav group enabled.
Issues Resolved
#7244
Screenshot
Testing the changes
All changes working fine in the feature/navigation-next branch. Need to checkout the code and rebase
feature/navigation-nextbranch.Another way is to refer the
src/plugins/workspace/public/plugin.test.tsunit test file. All changes have been covered in it.Changelog
Check List
yarn test:jestyarn test:jest_integration