-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sample Data] Update demo dashboard title #7233
Merged
ashwin-pc
merged 4 commits into
opensearch-project:main
from
ashwin-pc:fix/demo-dashboard-title
Jul 28, 2024
Merged
[Sample Data] Update demo dashboard title #7233
ashwin-pc
merged 4 commits into
opensearch-project:main
from
ashwin-pc:fix/demo-dashboard-title
Jul 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashwin P Chandran <[email protected]>
ashwin-pc
requested review from
ananzh,
kavilla,
AMoo-Miki,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27 and
virajsanghvi
as code owners
July 12, 2024 19:49
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7233 +/- ##
=======================================
Coverage 67.71% 67.71%
=======================================
Files 3518 3518
Lines 69638 69638
Branches 11365 11365
=======================================
+ Hits 47153 47155 +2
+ Misses 19696 19695 -1
+ Partials 2789 2788 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hailong-am
reviewed
Jul 26, 2024
src/plugins/home/server/services/sample_data/data_sets/logs/saved_objects.ts
Show resolved
Hide resolved
kavilla
approved these changes
Jul 28, 2024
ruanyl
approved these changes
Jul 28, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 28, 2024
* [Sample Data] Update demo dashboard title Signed-off-by: Ashwin P Chandran <[email protected]> * Changeset file for PR #7233 created/updated --------- Signed-off-by: Ashwin P Chandran <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 3880036) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 28, 2024
* [Sample Data] Update demo dashboard title Signed-off-by: Ashwin P Chandran <[email protected]> * Changeset file for PR #7233 created/updated --------- Signed-off-by: Ashwin P Chandran <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 3880036) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ananzh
pushed a commit
that referenced
this pull request
Jul 29, 2024
* [Sample Data] Update demo dashboard title * Changeset file for PR #7233 created/updated --------- (cherry picked from commit 3880036) Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Ashwin P Chandran <[email protected]>
Qxisylolo
pushed a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Aug 1, 2024
* [Sample Data] Update demo dashboard title Signed-off-by: Ashwin P Chandran <[email protected]> * Changeset file for PR opensearch-project#7233 created/updated --------- Signed-off-by: Ashwin P Chandran <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the sample dashboard title and description that shows the various visualizations to better reflect what it is.
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration