Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Look&Feel] Update dashboards & visualization list title to use standard size #7226

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

zhongnansu
Copy link
Member

@zhongnansu zhongnansu commented Jul 11, 2024

Description

image

Issues Resolved

Screenshot

Testing the changes

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

AMoo-Miki
AMoo-Miki previously approved these changes Jul 11, 2024
@github-actions github-actions bot added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry and removed failed changeset labels Jul 11, 2024
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.57%. Comparing base (a2ee362) to head (8ba64e5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7226      +/-   ##
==========================================
+ Coverage   67.55%   67.57%   +0.01%     
==========================================
  Files        3469     3469              
  Lines       68479    68479              
  Branches    11130    11130              
==========================================
+ Hits        46264    46276      +12     
+ Misses      19512    19500      -12     
  Partials     2703     2703              
Flag Coverage Δ
Linux_1 33.13% <ø> (ø)
Linux_2 55.26% <ø> (ø)
Linux_3 45.30% <ø> (-0.02%) ⬇️
Linux_4 34.71% <ø> (ø)
Windows_1 33.18% <ø> (+0.02%) ⬆️
Windows_2 55.21% <ø> (ø)
Windows_3 45.32% <ø> (ø)
Windows_4 34.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@virajsanghvi virajsanghvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good - can you fix test?

@zhongnansu
Copy link
Member Author

zhongnansu commented Jul 12, 2024

Change looks good - can you fix test?

failed test doesn't seem to be related to my change. Re running the CI to see if it passes.

Re-run failed, but I also notice the same CI group 6 failed for other PRs. We don't need to be blocked by the non-related failed CI

@zhongnansu zhongnansu merged commit c3dd768 into opensearch-project:main Jul 12, 2024
66 of 67 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 12, 2024
…d size (#7226)

Signed-off-by: Zhongnan Su <[email protected]>
(cherry picked from commit c3dd768)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@zhongnansu zhongnansu added the enhancement New feature or request label Jul 12, 2024
zhongnansu pushed a commit that referenced this pull request Jul 18, 2024
…d size (#7226) (#7234)

(cherry picked from commit c3dd768)

Signed-off-by: Zhongnan Su <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x enhancement New feature or request in-next look & feel Look and Feel Improvements Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants