Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO_NOT_MERGE] New navigation feature branch #7134

Closed
wants to merge 2 commits into from

Conversation

SuZhou-Joe
Copy link
Member

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

github-actions bot commented Jul 1, 2024

ℹ️ Manual Changeset Creation Reminder

Please ensure manual commit for changeset file 7134.yml under folder changelogs/fragments to complete this PR.

If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link.

For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool.

@github-actions github-actions bot added failed changeset and removed Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Jul 1, 2024
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 71.73397% with 119 lines in your changes missing coverage. Please review.

Project coverage is 67.52%. Comparing base (d2e7b9d) to head (eaf5fea).
Report is 1 commits behind head on main.

Files Patch % Lines
...rc/plugins/home/public/application/home_render.tsx 11.53% 23 Missing ⚠️
src/plugins/content_management/public/plugin.ts 0.00% 15 Missing ⚠️
...chrome/ui/header/collapsible_nav_group_enabled.tsx 87.01% 2 Missing and 8 partials ⚠️
...tent_management/public/components/section_input.ts 86.76% 3 Missing and 6 partials ⚠️
src/plugins/home/public/plugin.ts 22.22% 6 Missing and 1 partial ⚠️
src/core/public/chrome/ui/header/header.tsx 14.28% 6 Missing ⚠️
...nt_management/public/components/section_render.tsx 84.37% 2 Missing and 3 partials ⚠️
...agement/public/services/content_management/page.ts 80.00% 1 Missing and 4 partials ⚠️
...rc/plugins/data_source_management/public/plugin.ts 54.54% 4 Missing and 1 partial ⚠️
.../plugins/index_pattern_management/public/plugin.ts 54.54% 4 Missing and 1 partial ⚠️
... and 11 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7134      +/-   ##
==========================================
+ Coverage   67.30%   67.52%   +0.21%     
==========================================
  Files        3500     3519      +19     
  Lines       69219    69637     +418     
  Branches    11275    11356      +81     
==========================================
+ Hits        46591    47022     +431     
+ Misses      19903    19843      -60     
- Partials     2725     2772      +47     
Flag Coverage Δ
Linux_1 ?
Linux_2 55.46% <85.04%> (+0.16%) ⬆️
Linux_3 43.26% <48.35%> (-2.01%) ⬇️
Windows_1 33.16% <3.57%> (-0.11%) ⬇️
Windows_2 55.41% <85.04%> (+0.16%) ⬆️
Windows_3 43.28% <48.35%> (-2.00%) ⬇️
Windows_4 34.53% <9.73%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe force-pushed the feature/navigation-next branch 5 times, most recently from 84537b5 to d73444b Compare July 17, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant