Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing aria-label for discover page #6898

Merged
merged 5 commits into from
Jun 10, 2024

Conversation

abbyhu2000
Copy link
Member

@abbyhu2000 abbyhu2000 commented Jun 3, 2024

Description

Add missing aria-label for discover page.

Issues Resolved

resolves 1.1.1 Non-text Content (Level A) Web of #6897

Changelog

  • fix: Add missing aria-label for discover page

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.44%. Comparing base (7eaab64) to head (58f95c9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6898   +/-   ##
=======================================
  Coverage   67.44%   67.44%           
=======================================
  Files        3442     3442           
  Lines       67816    67816           
  Branches    11027    11027           
=======================================
  Hits        45740    45740           
  Misses      19409    19409           
  Partials     2667     2667           
Flag Coverage Δ
Linux_1 33.08% <ø> (ø)
Linux_2 55.11% <ø> (ø)
Linux_3 45.19% <ø> (ø)
Linux_4 34.86% <ø> (ø)
Windows_1 33.10% <ø> (ø)
Windows_2 55.06% <ø> (ø)
Windows_3 45.21% <ø> (ø)
Windows_4 34.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kavilla
Copy link
Member

kavilla commented Jun 4, 2024

do you have the changelog bot installed for your github?

@kavilla kavilla added backport 2.x discover for discover reinvent labels Jun 4, 2024
@BionIT
Copy link
Collaborator

BionIT commented Jun 5, 2024

Hi @abbyhu2000 , is this PR targeting 2.15 or 2.16?

@abbyhu2000
Copy link
Member Author

Hi @abbyhu2000 , is this PR targeting 2.15 or 2.16?

It is for 2.15, i have added the label

ashwin-pc
ashwin-pc previously approved these changes Jun 7, 2024
Signed-off-by: abbyhu2000 <[email protected]>
@ananzh ananzh merged commit e2f2380 into opensearch-project:main Jun 10, 2024
67 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6898-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e2f23802d7ba25ec8020c5a454f2a0ed435b78d7
# Push it to GitHub
git push --set-upstream origin backport/backport-6898-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-6898-to-2.x.

abbyhu2000 added a commit to abbyhu2000/OpenSearch-Dashboards that referenced this pull request Jun 10, 2024
* add missing aria-label for discover page
* Update snapshot
* add localization and make it human-readable

---------

Signed-off-by: abbyhu2000 <[email protected]>
BionIT pushed a commit that referenced this pull request Jun 10, 2024
* add missing aria-label for discover page
* Update snapshot
* add localization and make it human-readable

---------

Signed-off-by: abbyhu2000 <[email protected]>
ananzh pushed a commit that referenced this pull request Jun 10, 2024
* Add changelog

Signed-off-by: abbyhu2000 <[email protected]>

* add another changelog

Signed-off-by: abbyhu2000 <[email protected]>

---------

Signed-off-by: abbyhu2000 <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 10, 2024
* Add changelog

Signed-off-by: abbyhu2000 <[email protected]>

* add another changelog

Signed-off-by: abbyhu2000 <[email protected]>

---------

Signed-off-by: abbyhu2000 <[email protected]>
(cherry picked from commit e21c17a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ananzh pushed a commit that referenced this pull request Jun 10, 2024
* Add changelog
* add another changelog



---------


(cherry picked from commit e21c17a)

Signed-off-by: abbyhu2000 <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
l0rdn1kk0n pushed a commit to l0rdn1kk0n/OpenSearch-Dashboards that referenced this pull request Jun 11, 2024
* Add changelog

Signed-off-by: abbyhu2000 <[email protected]>

* add another changelog

Signed-off-by: abbyhu2000 <[email protected]>

---------

Signed-off-by: abbyhu2000 <[email protected]>
Signed-off-by: Michael Haitz <[email protected]>
l0rdn1kk0n pushed a commit to l0rdn1kk0n/OpenSearch-Dashboards that referenced this pull request Jun 11, 2024
* Add changelog

Signed-off-by: abbyhu2000 <[email protected]>

* add another changelog

Signed-off-by: abbyhu2000 <[email protected]>

---------

Signed-off-by: abbyhu2000 <[email protected]>
Signed-off-by: Michael Haitz <[email protected]>
@zhyuanqi zhyuanqi added the enhancement New feature or request label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants