Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Multiple datasource] Adjust the padding size for aggregated view #6896

Merged
merged 1 commit into from
Jun 3, 2024

Commits on Jun 3, 2024

  1. [Multiple datasource] Adjust the padding size for aggregated view (#6715

    )
    
    * adjust the aggregated view padding
    
    Signed-off-by: yujin-emma <[email protected]>
    
    * WIP
    
    Signed-off-by: yujin-emma <[email protected]>
    
    * Update src/plugins/data_source_management/public/components/data_source_aggregated_view/data_source_aggregated_view.tsx
    
    Co-authored-by: Xinrui Bai-amazon <[email protected]>
    Signed-off-by: Yu Jin <[email protected]>
    Signed-off-by: yujin-emma <[email protected]>
    
    * Changeset file for PR #6715 created/updated
    
    Signed-off-by: yujin-emma <[email protected]>
    
    * Update CHANGELOG.md
    
    Signed-off-by: yujin-emma <[email protected]>
    
    * [saved objects] enable deletion of saved objects by type if configured (#6443)
    
    * [saved objects] enable deletion of saved objects by type if configured
    
    Adds the following settings:
    ```
    migrations.delete.enabled
    migrations.delete.types
    ```
    
    `unknown` types already exist but the purpose of this type is for plugins
    that are disabled. OpenSearch Dashboards gets confused when a plugin is not
    defining a saved object type but the saved object exists. This can occur
    when migrating from a non-OSD version and there exists non-compatiable
    saved objects.
    
    If OSD is failing to migrate an index because of a document, I can now
    configure OSD to delete types of saved objects that I specified because
    I know that these types should not be carried over.
    
    resolves: #1040
    
    Signed-off-by: Kawika Avilla <[email protected]>
    
    * address comments
    
    Signed-off-by: Kawika Avilla <[email protected]>
    
    * Changeset file for PR #6443 created/updated
    
    ---------
    
    Signed-off-by: Kawika Avilla <[email protected]>
    Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
    Signed-off-by: yujin-emma <[email protected]>
    
    * [tests] fix tests related to #6443 (#6722)
    
    * [tests] fix tests related to #6443
    
    PR: 6443 merged in previous PR that had an immediate follow up PR
    to that PR. But the followup pr was not merged into 6443.
    
    The snapshots got updated to ensure the CI passed for 6443. But
    once merged into main, failures were observed.
    
    Signed-off-by: Kawika Avilla <[email protected]>
    
    * Changeset file for PR #6722 created/updated
    
    ---------
    
    Signed-off-by: Kawika Avilla <[email protected]>
    Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
    Signed-off-by: yujin-emma <[email protected]>
    
    * feat: add config for topRightNavigation (#6712)
    
    * feat: add config for topRightNavigation
    
    Signed-off-by: tygao <[email protected]>
    
    * doc: update changelog
    
    Signed-off-by: tygao <[email protected]>
    
    * Changeset file for PR #6712 created/updated
    
    * test: update context test
    
    Signed-off-by: tygao <[email protected]>
    
    * doc: update changelog
    
    Signed-off-by: tygao <[email protected]>
    
    * update changeset
    
    Signed-off-by: tygao <[email protected]>
    
    * update joi default value
    
    Signed-off-by: tygao <[email protected]>
    
    * add experimental annotation and add futureNavigation configuration
    
    Signed-off-by: tygao <[email protected]>
    
    * add experimental annotation and add futureNavigation configuration
    
    Signed-off-by: tygao <[email protected]>
    
    ---------
    
    Signed-off-by: tygao <[email protected]>
    Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
    Co-authored-by: Ashwin P Chandran <[email protected]>
    Signed-off-by: yujin-emma <[email protected]>
    
    * move the css to the data source aggregated view
    
    Signed-off-by: yujin-emma <[email protected]>
    
    * [Multiple Datasource Test]add more test for icon and aggregated view (#6729)
    
    * add more test for icon and aggregated view
    
    Signed-off-by: yujin-emma <[email protected]>
    
    * Changeset file for PR #6729 created/updated
    
    * Update CHANGELOG.md
    
    ---------
    
    Signed-off-by: yujin-emma <[email protected]>
    Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
    Signed-off-by: yujin-emma <[email protected]>
    
    * update css file space and use the oui color guideline number to replace the color name in css file
    
    Signed-off-by: yujin-emma <[email protected]>
    
    * [OSD Availability] Prevent OSD process crashes when disk is full (#6733)
    
    * prevent crash when disk full
    
    Signed-off-by: Flyingliuhub <[email protected]>
    
    * change verbose to false
    
    Signed-off-by: Flyingliuhub <[email protected]>
    
    * add changeset file
    
    Signed-off-by: Flyingliuhub <[email protected]>
    
    * update changeset contexts
    
    Signed-off-by: Flyingliuhub <[email protected]>
    
    * change feature flag name
    
    Signed-off-by: Flyingliuhub <[email protected]>
    
    ---------
    
    Signed-off-by: Flyingliuhub <[email protected]>
    Co-authored-by: ZilongX <[email protected]>
    Signed-off-by: yujin-emma <[email protected]>
    
    * [MDS] Modify toast + popover warning to include incompatible datasources (#6678)
    
    * Fix merge conflict
    
    Signed-off-by: Huy Nguyen <[email protected]>
    
    * Refactor to incompatibleDataSourcesExist
    
    Signed-off-by: Huy Nguyen <[email protected]>
    
    * Changeset file for PR #6678 created/updated
    
    * Move required args to the top
    
    Signed-off-by: Huy Nguyen <[email protected]>
    
    ---------
    
    Signed-off-by: Huy Nguyen <[email protected]>
    Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
    Signed-off-by: yujin-emma <[email protected]>
    
    * [Multiple Datasource Test] Add test for edit data source form (#6742)
    
    * add test for edit data source form
    
    Signed-off-by: yujin-emma <[email protected]>
    
    * Changeset file for PR #6742 created/updated
    
    ---------
    
    Signed-off-by: yujin-emma <[email protected]>
    Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
    Signed-off-by: yujin-emma <[email protected]>
    
    * [MQL] support enhancing language selector (#6613)
    
    Enable with `data.enhancements.enabled: true`
    
    Allows for enhancing the data plugin UI service and search service.
    
    #### Remaining work
    * Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language
      * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range.
    * Add tests
    * Disable for plugins that do not support the functionality
      * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices).
      * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id.
      * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory.
    
    ### Issues Resolved
    
    closes #6639
    closes #6311
    
    partially resolves:
    #5504
    
    * add error data frame
    
    Signed-off-by: Paul Sebastian <[email protected]>
    
    move language to left, some styling and disable per app name
    
    Signed-off-by: Kawika Avilla <[email protected]>
    
    ---------
    
    Signed-off-by: Kawika Avilla <[email protected]>
    Signed-off-by: Paul Sebastian <[email protected]>
    Co-authored-by: Paul Sebastian <[email protected]>
    Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
    Signed-off-by: yujin-emma <[email protected]>
    
    * Make Field Name Search Filter Case Insensitive (#6759)
    
    * Make Field Name Filter Case Insensitive
    
    Signed-off-by: Suchit Sahoo <[email protected]>
    
    * Changeset file for PR #6759 created/updated
    
    ---------
    
    Signed-off-by: Suchit Sahoo <[email protected]>
    Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
    Signed-off-by: yujin-emma <[email protected]>
    
    * [Multiple Datasource Test] Add test for error_menu, item, data_source_multi_selectable (#6752)
    
    * add test for data_source_error_menu, data_source_item, data_source_multi_selectable
    
    Signed-off-by: yujin-emma <[email protected]>
    
    * Changeset file for PR #6752 created/updated
    
    * add content verify in test
    
    Signed-off-by: yujin-emma <[email protected]>
    
    ---------
    
    Signed-off-by: yujin-emma <[email protected]>
    Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
    Signed-off-by: yujin-emma <[email protected]>
    
    * [2.14][chore] update release notes (#6705)
    
    Updates releases notes. Partially populated with: yarn release_note:generate
    
    And gathered the rest. Cleaned up changelog.
    
    related to: #6254
    
    Signed-off-by: Kawika Avilla <[email protected]>
    Signed-off-by: yujin-emma <[email protected]>
    
    * add http://www.site.com to lycheeignore (#6771)
    
    * add http://www.site.com to lycheeignore
    
    Signed-off-by: yujin-emma <[email protected]>
    
    * Changeset file for PR #6771 created/updated
    
    * Update .lycheeignore
    
    Co-authored-by: Miki <[email protected]>
    Signed-off-by: Yu Jin <[email protected]>
    
    ---------
    
    Signed-off-by: yujin-emma <[email protected]>
    Signed-off-by: Yu Jin <[email protected]>
    Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
    Co-authored-by: Miki <[email protected]>
    Signed-off-by: yujin-emma <[email protected]>
    
    * [Workspace] Fix: Show a error toast when workspace read only user delete saved objects (#6756)
    
    * fix: show a error toast when workspace read only user delete saved objects
    
    Signed-off-by: yubonluo <[email protected]>
    
    * Changeset file for PR #6756 created/updated
    
    * Changeset file for PR #6756 created/updated
    
    * optimize the code
    
    Signed-off-by: yubonluo <[email protected]>
    
    * Display the delete modal after failing to delete.
    
    Signed-off-by: yubonluo <[email protected]>
    
    * Add some unit tests
    
    Signed-off-by: yubonluo <[email protected]>
    
    * Add some state assertions
    
    Signed-off-by: yubonluo <[email protected]>
    
    ---------
    
    Signed-off-by: yubonluo <[email protected]>
    Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
    Signed-off-by: yujin-emma <[email protected]>
    
    * Updating security reachout email (#6778)
    
    Signed-off-by: varun-lodaya <[email protected]>
    Signed-off-by: yujin-emma <[email protected]>
    
    * add @zhyuanqi as a maintainer (#6788)
    
    * add @zhyuanqi as a maintainer
    
    ---------
    
    Signed-off-by: Lu Yu <[email protected]>
    Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
    Signed-off-by: yujin-emma <[email protected]>
    
    * [OE] Adds dev doc script to precommit hook (#6585)
    
    * Adds doc generation to pre commit hook
    
    Signed-off-by: Ashwin P Chandran <[email protected]>
    
    * Add check hook to pre commit
    
    Signed-off-by: Ashwin P Chandran <[email protected]>
    
    * Changeset file for PR #6585 created/updated
    
    * Update error message
    
    Signed-off-by: Ashwin P Chandran <[email protected]>
    
    * Improve error message
    
    Co-authored-by: Miki <[email protected]>
    Signed-off-by: Ashwin P Chandran <[email protected]>
    
    * fixes lint issue
    
    Signed-off-by: Ashwin P Chandran <[email protected]>
    
    ---------
    
    Signed-off-by: Ashwin P Chandran <[email protected]>
    Signed-off-by: Ashwin P Chandran <[email protected]>
    Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
    Co-authored-by: Miki <[email protected]>
    Signed-off-by: yujin-emma <[email protected]>
    
    * Move @BSFishy to emeritus maintainer (#6790)
    
    * Move @BSFishy to emeritus maintainer
    
    Signed-off-by: Lu Yu <[email protected]>
    
    * Changeset file for PR #6790 created/updated
    
    ---------
    
    Signed-off-by: Lu Yu <[email protected]>
    Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
    Signed-off-by: yujin-emma <[email protected]>
    
    * add @mengweieric as maintainer (#6798)
    
    * add @mengweieric as maintainer
    
    Signed-off-by: Lu Yu <[email protected]>
    
    * Changeset file for PR #6798 created/updated
    
    ---------
    
    Signed-off-by: Lu Yu <[email protected]>
    Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
    Signed-off-by: yujin-emma <[email protected]>
    
    * Add OpenAPI specification for get and create saved object APIs  (#6799)
    
    * add openapi doc
    
    Signed-off-by: Lu Yu <[email protected]>
    
    * add readme
    
    Signed-off-by: Lu Yu <[email protected]>
    
    * Changeset file for PR #6799 created/updated
    
    ---------
    
    Signed-off-by: Lu Yu <[email protected]>
    Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
    Signed-off-by: yujin-emma <[email protected]>
    
    * [Multiple Datasource Test]Add test for toast button and validation form (#6755)
    
    * add test for toast button and validation form
    
    Signed-off-by: yujin-emma <[email protected]>
    
    * Changeset file for PR #6755 created/updated
    
    Signed-off-by: yujin-emma <[email protected]>
    
    * Update src/plugins/data_source_management/public/components/toast_button/manage_data_source_button.tsx
    
    Co-authored-by: Lu Yu <[email protected]>
    Signed-off-by: Yu Jin <[email protected]>
    Signed-off-by: yujin-emma <[email protected]>
    
    * Update manage_data_source_button.test.tsx
    
    Signed-off-by: yujin-emma <[email protected]>
    
    * [Multiple Datasource Test] Add test for edit data source form (#6742)
    
    * add test for edit data source form
    
    Signed-off-by: yujin-emma <[email protected]>
    
    * Changeset file for PR #6742 created/updated
    
    ---------
    
    Signed-off-by: yujin-emma <[email protected]>
    Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
    Signed-off-by: yujin-emma <[email protected]>
    
    * [MQL] support enhancing language selector (#6613)
    
    Enable with `data.enhancements.enabled: true`
    
    Allows for enhancing the data plugin UI service and search service.
    
    #### Remaining work
    * Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language
      * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range.
    * Add tests
    * Disable for plugins that do not support the functionality
      * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices).
      * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id.
      * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory.
    
    ### Issues Resolved
    
    closes #6639
    closes #6311
    
    partially resolves:
    #5504
    
    * add error data frame
    
    Signed-off-by: Paul Sebastian <[email protected]>
    
    move language to left, some styling and disable per app name
    
    Signed-off-by: Kawika Avilla <[email protected]>
    
    ---------
    
    Signed-off-by: Kawika Avilla <[email protected]>
    Signed-off-by: Paul Sebastian <[email protected]>
    Co-authored-by: Paul Sebastian <[email protected]>
    Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
    Signed-off-by: yujin-emma <[email protected]>
    
    * Make Field Name Search Filter Case Insensitive (#6759)
    
    * Make Field Name Filter Case Insensitive
    
    Signed-off-by: Suchit Sahoo <[email protected]>
    
    * Changeset file for PR #6759 created/updated
    
    ---------
    
    Signed-off-by: Suchit Sahoo <[email protected]>
    Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
    Signed-off-by: yujin-emma <[email protected]>
    
    * address naming for manage data source button test id
    
    Signed-off-by: yujin-emma <[email protected]>
    
    ---------
    
    Signed-off-by: yujin-emma <[email protected]>
    Signed-off-by: Yu Jin <[email protected]>
    Signed-off-by: Kawika Avilla <[email protected]>
    Signed-off-by: Paul Sebastian <[email protected]>
    Signed-off-by: Suchit Sahoo <[email protected]>
    Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
    Co-authored-by: Lu Yu <[email protected]>
    Co-authored-by: Kawika Avilla <[email protected]>
    Co-authored-by: Paul Sebastian <[email protected]>
    Co-authored-by: Suchit Sahoo <[email protected]>
    Signed-off-by: yujin-emma <[email protected]>
    
    ---------
    
    Signed-off-by: yujin-emma <[email protected]>
    Signed-off-by: Yu Jin <[email protected]>
    Signed-off-by: Kawika Avilla <[email protected]>
    Signed-off-by: tygao <[email protected]>
    Signed-off-by: Flyingliuhub <[email protected]>
    Signed-off-by: Huy Nguyen <[email protected]>
    Signed-off-by: Paul Sebastian <[email protected]>
    Signed-off-by: Suchit Sahoo <[email protected]>
    Signed-off-by: yubonluo <[email protected]>
    Signed-off-by: varun-lodaya <[email protected]>
    Signed-off-by: Lu Yu <[email protected]>
    Signed-off-by: Ashwin P Chandran <[email protected]>
    Signed-off-by: Ashwin P Chandran <[email protected]>
    Co-authored-by: Xinrui Bai-amazon <[email protected]>
    Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
    Co-authored-by: Kawika Avilla <[email protected]>
    Co-authored-by: tygao <[email protected]>
    Co-authored-by: Ashwin P Chandran <[email protected]>
    Co-authored-by: Tao Liu <[email protected]>
    Co-authored-by: ZilongX <[email protected]>
    Co-authored-by: Huy Nguyen <[email protected]>
    Co-authored-by: Paul Sebastian <[email protected]>
    Co-authored-by: Suchit Sahoo <[email protected]>
    Co-authored-by: Miki <[email protected]>
    Co-authored-by: yuboluo <[email protected]>
    Co-authored-by: Varun Lodaya <[email protected]>
    Co-authored-by: Lu Yu <[email protected]>
    (cherry picked from commit 9ef7404)
    Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
    15 people committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    ce22116 View commit details
    Browse the repository at this point in the history