[Backport 2.x] [Multiple Datasource] Add data source selection service to support storing and getting selected data source updates #6875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…oring and getting selected data source updates (#6827) * add data source selection service Signed-off-by: tygao <[email protected]> * export generateComponentId in util Signed-off-by: tygao <[email protected]> * update tests and type Signed-off-by: tygao <[email protected]> * update tests Signed-off-by: tygao <[email protected]> * update bind in components Signed-off-by: tygao <[email protected]> * Changeset file for PR #6827 created/updated * test: add tests for service Signed-off-by: tygao <[email protected]> * move dataSourceSelection out of componoent props Signed-off-by: tygao <[email protected]> * update service class name Signed-off-by: tygao <[email protected]> * use getter to replace dataSourceSelection props Signed-off-by: tygao <[email protected]> * add fallback for getter Signed-off-by: tygao <[email protected]> * test: add selection test case for component Signed-off-by: tygao <[email protected]> --------- Signed-off-by: tygao <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Lu Yu <[email protected]> (cherry picked from commit e2c0df2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
added
autocut
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi and
mengweieric
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6875 +/- ##
==========================================
+ Coverage 67.42% 67.45% +0.02%
==========================================
Files 3442 3443 +1
Lines 67823 67860 +37
Branches 11023 11021 -2
==========================================
+ Hits 45733 45774 +41
+ Misses 19426 19425 -1
+ Partials 2664 2661 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
approved these changes
May 31, 2024
BionIT
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport e2c0df2 from #6827.