Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Workspace] Dashboard admin(groups/users) implementation #6829

Merged
merged 1 commit into from
May 27, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport b839da1 from #6554.

* [Workspace] dashboard admin(groups/users) implementation and integrating with dynamic application config

Signed-off-by: yubonluo <[email protected]>

* Modify change log

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* modify change log

Signed-off-by: yubonluo <[email protected]>

* modify change log

Signed-off-by: yubonluo <[email protected]>

* solve change log issue

Signed-off-by: yubonluo <[email protected]>

* Changeset file for PR #6554 created/updated

* [Workspace] delete useless code

Signed-off-by: yubonluo <[email protected]>

* Changeset file for PR #6554 created/updated

* delete useless code

Signed-off-by: yubonluo <[email protected]>

* Optimize the code

Signed-off-by: yubonluo <[email protected]>

* Add unit test to cover setupPermission in plugin.

Signed-off-by: yubonluo <[email protected]>

* delete the logic of dynamic application config

Signed-off-by: yubonluo <[email protected]>

* Default to OSD admin if security uninstall

Signed-off-by: yubonluo <[email protected]>

* Default to OSD admin if security uninstall

Signed-off-by: yubonluo <[email protected]>

---------

Signed-off-by: yubonluo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit b839da1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 96.77419% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 67.61%. Comparing base (ecfaed5) to head (5c05e0e).

Files Patch % Lines
src/plugins/workspace/server/plugin.ts 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #6829      +/-   ##
==========================================
+ Coverage   67.60%   67.61%   +0.01%     
==========================================
  Files        3427     3427              
  Lines       67357    67383      +26     
  Branches    10983    10990       +7     
==========================================
+ Hits        45535    45561      +26     
- Misses      19157    19203      +46     
+ Partials     2665     2619      -46     
Flag Coverage Δ
Linux_1 33.11% <96.77%> (+0.03%) ⬆️
Linux_2 55.16% <100.00%> (ø)
Linux_3 45.20% <0.00%> (ø)
Linux_4 34.88% <0.00%> (ø)
Windows_1 33.13% <96.77%> (+0.03%) ⬆️
Windows_2 55.13% <100.00%> (ø)
Windows_3 45.22% <0.00%> (ø)
Windows_4 34.88% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit fad6971 into 2.x May 27, 2024
92 of 93 checks passed
@github-actions github-actions bot deleted the backport/backport-6554-to-2.x branch May 27, 2024 02:42
@zhyuanqi zhyuanqi added the enhancement New feature or request label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports enhancement New feature or request first-time-contributor v2.15.0 workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants