Add default and value check for theme user specific keys #6714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue Resolve opensearch-project#6704 Signed-off-by: Anan Zhuang <[email protected]>
ananzh
requested review from
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT and
xinruiba
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6714 +/- ##
=======================================
Coverage 67.70% 67.70%
=======================================
Files 3417 3417
Lines 66922 66922
Branches 10888 10888
=======================================
Hits 45308 45308
Misses 18967 18967
Partials 2647 2647
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kavilla
requested changes
May 3, 2024
| @@ -11,8 +11,13 @@ if (window.__osdStrictCsp__ && window.__osdCspNotEnforced__) { | |||
| window.console.log("^ A single error about an inline script not firing due to content security policy is expected!"); | |||
| } | |||
|
|
|||
| var isDarkMode = window.__osdThemeTag__.endsWith('dark'); | |||
| var themeVersion = window.__osdThemeTag__.startsWith('v7') ? 'v7' : 'v8'; | |||
| var isDarkMode = false; | |||
There was a problem hiding this comment.
Keep this the same as before no issue here
| var isDarkMode = window.__osdThemeTag__.endsWith('dark'); | ||
| var themeVersion = window.__osdThemeTag__.startsWith('v7') ? 'v7' : 'v8'; | ||
| var isDarkMode = false; | ||
| var themeVersion = ''; |
There was a problem hiding this comment.
If global window undefined no theme will be set
|
|
||
| if (window.__osdThemeTag__) { | ||
| isDarkMode = window.__osdThemeTag__.endsWith('dark'); | ||
| themeVersion = window.__osdThemeTag__.startsWith('v7') ? 'v7' : 'v8'; |
There was a problem hiding this comment.
Instead using a nested if statement can't we just do.
Check if it's undefined here or not and get the value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Resolved
#6704
Changelog
Check List
yarn test:jestyarn test:jest_integration