Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.13] [Backport 2.x] [MDS] Support Vega Visualizations #6221

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 05ede47 from #6212.

* Add MDS support for Vega

Signed-off-by: Huy Nguyen <[email protected]>

* Refactor field to data_source_id

Signed-off-by: Huy Nguyen <[email protected]>

* Add to CHANGELOG.md

Signed-off-by: Huy Nguyen <[email protected]>

* Added test cases and renamed field to use data_source_name

Signed-off-by: Huy Nguyen <[email protected]>

* Add prefix datasource name test case and add example in default hjson

Signed-off-by: Huy Nguyen <[email protected]>

* Move CHANGELOG to appropriate section

Signed-off-by: Huy Nguyen <[email protected]>

* Increased test coverage of search() method

Signed-off-by: Huy Nguyen <[email protected]>

---------

Signed-off-by: Huy Nguyen <[email protected]>
(cherry picked from commit 1c5ad6c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 05ede47)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 77.27273% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 67.20%. Comparing base (693e0c0) to head (54f892c).

Files Patch % Lines
...gins/vis_type_vega/public/data_model/search_api.ts 73.68% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             2.13    #6221      +/-   ##
==========================================
+ Coverage   67.18%   67.20%   +0.01%     
==========================================
  Files        3332     3332              
  Lines       64435    64448      +13     
  Branches    10289    10293       +4     
==========================================
+ Hits        43292    43311      +19     
+ Misses      18643    18636       -7     
- Partials     2500     2501       +1     
Flag Coverage Δ
Linux_1 35.11% <77.27%> (+0.03%) ⬆️
Linux_2 55.28% <ø> (ø)
Linux_3 44.76% <ø> (+0.01%) ⬆️
Linux_4 35.35% <ø> (ø)
Windows_1 35.14% <77.27%> (+0.03%) ⬆️
Windows_2 55.24% <ø> (ø)
Windows_3 44.76% <ø> (ø)
Windows_4 35.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BionIT BionIT merged commit 3d89a42 into 2.13 Mar 20, 2024
89 of 90 checks passed
@github-actions github-actions bot deleted the backport/backport-6212-to-2.13 branch March 20, 2024 03:43
@BionIT BionIT added the v2.13.0 label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports first-time-contributor multiple datasource multiple datasource project v2.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants