Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore devDependencies version mismatch in bootstrap #5561

Closed
derek-ho opened this issue Nov 30, 2023 · 9 comments · Fixed by #5675
Closed

Ignore devDependencies version mismatch in bootstrap #5561

derek-ho opened this issue Nov 30, 2023 · 9 comments · Fixed by #5675
Labels

Comments

@derek-ho
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Security dashboards plugin was recently cut a ticket for a build failure: opensearch-project/security-dashboards-plugin#1682 (comment). Locally, matching the version in package.json solves this type of issue, but not sure if this is scalable long term, and especially for devDependencies matching the version should matter less?

Describe the solution you'd like

Ignore/skip/provide some other long term solution for dependency resolution/matching

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

@derek-ho derek-ho added the enhancement New feature or request label Nov 30, 2023
@derek-ho
Copy link
Contributor Author

@kavilla / @ashwin-pc I saw that there was some discussion about this before, but I wasn't able to find a resolution - can you advise here on if there is a fix from core side or we should just try to manually match the package.json versions?

@abbyhu2000
Copy link
Member

abbyhu2000 commented Dec 1, 2023

#3095 I found this RFC on decoupling the dependency.

@derek-ho
Copy link
Contributor Author

derek-ho commented Dec 4, 2023

Thanks, @abbyhu2000, @AMoo-Miki! Would it be feasible to fix this from dashboards side in near term, or should I still open issues in individual plugin repos to manually match the versions?

@wanglam
Copy link
Contributor

wanglam commented Jan 8, 2024

@derek-ho According the opensearch-build script, it will remove the success build plugin folder if everything goes well. According the build log, the root cause was dashboards-reporting build failed due to failed to run yarn osd bootstrap. I think we need to fix this issue first.

@ashwin-pc
Copy link
Member

@AMoo-Miki 's PR #5675 should allow for less restrictive version requirements.

@derek-ho
Copy link
Contributor Author

@ashwin-pc @AMoo-Miki any updates on this issue long term? We started seeing failures on bootstrap on main again:

[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning "@elastic/eslint-import-resolver-kibana > [email protected]" has unmet peer dependency "eslint-plugin-import@>=1.4.0".
warning " > @testing-library/[email protected]" has unmet peer dependency "react@>=16.9.0".
warning "@testing-library/react-hooks > [email protected]" has unmet peer dependency "react@>=16.13.1".
warning "cypress-mochawesome-reporter > [email protected]" has unmet peer dependency "mocha@>=7".
warning " > [email protected]" has unmet peer dependency "eslint@>= 3.2.1".
[4/4] Building fresh packages...

ERROR [single_version_dependencies] Multiple version ranges for the same dependency
      were found declared across different package.json files. Please consolidate
      those to match across all package.json files. Different versions for the
      same dependency is not supported.

      If you have questions about this please reach out to the operations team.

      The conflicting dependencies are:

        cypress
          9.5.4 => opensearch-dashboards
          ^13.6.0 => opensearch-security-dashboards

Any suggestions on path forward to unblock the CI/autocuts?

@derek-ho
Copy link
Contributor Author

Update: adding --single-version=loose as suggested in the linked PR fixed the bootstrapping process on local CI. Opensearch-build is not passing in this param, and until it is done so autocuts will be cut. Not sure what the process forward for this issue is, but ideally this parameter shouldn't be needed for devDependencies.

@peternied
Copy link
Member

peternied commented Feb 21, 2024

@ashwin-pc @AMoo-Miki Could you take a look at a pull request [1] in opensearch-build to make this the default for the distribution build process?

@AMoo-Miki
Copy link
Collaborator

OSD 2.12 shipped with #5675. Infra will take care of the PR on the build repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
6 participants