Temporary fix for a bug with Chrome 129 when handling mask-image (#8274)

* Temporary fix for a bug with Chrome 129 when handling mask-image Signed-off-by: Miki <[email protected]> * Changeset file for PR #8274 created/updated --------- Signed-off-by: Miki <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit cd6a909) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-project · Sep 20, 2024 · cfdb019 · cfdb019
1 parent 1f9ec15
commit cfdb019
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 0 deletions.
diff --git a/changelogs/fragments/8274.yml b/changelogs/fragments/8274.yml
@@ -0,0 +1,2 @@
+fix:
+- Add a temporary fix for a bug with Chrome 129 when handling mask-image ([#8274](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8274))
diff --git a/src/core/public/styles/_base.scss b/src/core/public/styles/_base.scss
@@ -63,3 +63,31 @@ $euiCollapsibleNavWidth: $euiSize * 20;
   height: auto;
   width: auto;
 }
+
+// Temporary fix for a bug with Chrome 129 when handling mask-image
+// OUI provides the mask-image used in these which Chrome 129 fails to render correctly.
+// It is not known if or when Chrome will fix this. Since almost all of these classes
+// are applied to elements with scrollbars where their content contained, containing the
+// paint is a safe solution.
+// This can be achieved with various tricks like transform: translate?(0) or
+// transform-style: preserve-3d but they add to the browsers workload; contain doesn't.
+// ToDo: Remove these when most used versions of Chrome no longer suffer from the bug.
+// From OUI: any ruleset containing mask-image
+.eui-yScrollWithShadows,
+.eui-xScrollWithShadows,
+.euiYScrollWithShadows,
+.euiDataGrid__controlScroll,
+.euiDataGridColumnSelector__columnList,
+.euiDataGridColumnSorting__fieldList,
+.euiFlyoutBody .euiFlyoutBody__overflow,
+.euiFlyoutBody .euiFlyoutBody__overflow.euiFlyoutBody__overflow--hasBanner,
+.euiModalBody .euiModalBody__overflow,
+.euiSelectableList__list,
+// For OSD: consumers of eui?ScrollWithShadows
+.osdQueryBar__textarea:not(:focus):not(:invalid),
+.osdSavedQueryManagement__list,
+.dscCanvas,
+.vbConfig,
+.vbSidenav__style {
+  contain: paint;
+}