Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InstitutionID to topology Institutions #4131

Merged

Conversation

CannonLock
Copy link
Collaborator

@CannonLock CannonLock commented Sep 5, 2024

? Means I need input
~ Means it wasn't available but also not needed
TODO Means it will be filled in pending OSG Institution creation

  • Add script to test that new ones have the field added
  • Wait for Janet to add the ones labeled TODO
  • Wait for Janet to inform on the ones with a ?

? Means I need input
~ Means it wasn't available but also not needed
TODO Means it will be filled in pending OSG Institution creation
? Means I need input
~ Means it wasn't available but also not needed
TODO Means it will be filled in pending OSG Institution creation
@CannonLock
Copy link
Collaborator Author

CannonLock commented Sep 5, 2024

@matyasselmeci What is the deal with CancerComputer? Hasn't been touched for 6 years, can we delete? Or are we confident enough in its death that I can mark its InstitutionID null for now?

@brianhlin
Copy link
Member

@CannonLock

? Means I need input

Could you provide the list in ticket here? It's hard to dig this up in the 220-file change

What is the deal with CancerComputer? Hasn't been touched for 6 years, can we delete? Or are we confident enough in its death that I can mark its InstitutionID null for now?

Let's just use null for now. I'm not sure if there's been any contributions lately but I don't think we'd want to fully remove it

@CannonLock
Copy link
Collaborator Author

@brianhlin I gave @jstathas a list in slack directly and we managed to get it resolved.

@CannonLock
Copy link
Collaborator Author

@brianhlin If you want a easy way to compare these entries with their names in the institution DB.

They are null if they have no resources as I saw no reason to map them.

facility_institution_mapping.txt

- Add Github action to check the id is added
- Add remaining ID's
@osg-cat
Copy link
Contributor

osg-cat commented Sep 9, 2024

@CannonLock

? Means I need input

Could you provide the list in ticket here? It's hard to dig this up in the 220-file change

What is the deal with CancerComputer? Hasn't been touched for 6 years, can we delete? Or are we confident enough in its death that I can mark its InstitutionID null for now?

Let's just use null for now. I'm not sure if there's been any contributions lately but I don't think we'd want to fully remove it

Cancer Computer rebranded as “Computing for Humanity” a while ago: https://www.computingforhumanity.com.

- Update script to print all errors then bail
- Fix erroneous change in WIPAC
Copy link
Collaborator

@matyasselmeci matyasselmeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@matyasselmeci matyasselmeci merged commit 2bb2514 into opensciencegrid:master Sep 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants