-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add InstitutionID to topology Institutions #4131
Add InstitutionID to topology Institutions #4131
Conversation
? Means I need input ~ Means it wasn't available but also not needed TODO Means it will be filled in pending OSG Institution creation
? Means I need input ~ Means it wasn't available but also not needed TODO Means it will be filled in pending OSG Institution creation
@matyasselmeci What is the deal with CancerComputer? Hasn't been touched for 6 years, can we delete? Or are we confident enough in its death that I can mark its InstitutionID null for now? |
Could you provide the list in ticket here? It's hard to dig this up in the 220-file change
Let's just use null for now. I'm not sure if there's been any contributions lately but I don't think we'd want to fully remove it |
@brianhlin I gave @jstathas a list in slack directly and we managed to get it resolved. |
Fix ? entries
Update api endpoint
Update api endpoint
Add Github action to check the id is added
@brianhlin If you want a easy way to compare these entries with their names in the institution DB. They are null if they have no resources as I saw no reason to map them. |
- Add Github action to check the id is added - Add remaining ID's
Cancer Computer rebranded as “Computing for Humanity” a while ago: https://www.computingforhumanity.com. |
- Update script to print all errors then bail
- Fix erroneous change in WIPAC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
? Means I need input
~ Means it wasn't available but also not needed
TODO Means it will be filled in pending OSG Institution creation