Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quoting issue in the last eval statement in set_var; also check for invalid variable names #174

Merged

Conversation

matyasselmeci
Copy link
Contributor

No description provided.

…or invalid variable names

Don't add extra quoting to the setting of the default value -- that
causes disconnection issues for some reason
Copy link
Member

@rynge rynge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matyasselmeci matyasselmeci merged commit 2d45355 into opensciencegrid:master Aug 13, 2024
4 checks passed
@matyasselmeci matyasselmeci deleted the pr/fix-eval-quoting branch August 13, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants