Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced CPUJOB_ON_GPUSLOT with the new RoomForCPUOnlyJobs #161

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

rynge
Copy link
Member

@rynge rynge commented Dec 13, 2023

The OSPool GPU glideins have switched to an expression to help backfill partionable GPU slots with CPU-only jobs, and leave some resources for potential future GPU jobs. RoomForCPUOnlyJobs is defined in:

https://github.com/opensciencegrid/osg-flock/blob/master/ospool-pilot/main/pilot/additional-htcondor-config#L95-L99

This PR aligns osgvo-docker-pilot with those glideins. The ALLOW_CPUJOB_ON_GPUSLOT configuration flag is removed as it never worked well.

Copy link
Contributor

@matyasselmeci matyasselmeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The START expression change doesn't quite match what's in our frontend config; see suggestion. I'm pre-approving though.

50-main.config Outdated Show resolved Hide resolved
50-main.config Outdated Show resolved Hide resolved
rynge and others added 2 commits December 13, 2023 14:23
Co-authored-by: Matyas Selmeci <[email protected]>
Co-authored-by: Matyas Selmeci <[email protected]>
@rynge
Copy link
Member Author

rynge commented Dec 13, 2023

Thanks - start expression is slightly different because the FE group is for only GPU resources, while the container has be able to run well on both non-GPU and GPU resources.

@matyasselmeci matyasselmeci merged commit 9a2c30d into opensciencegrid:master Dec 13, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants