Use tini when using cvmfsexec to handle signal propagation #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have an issue where if the container uses cvmfsexec to mount repos, then a SIGTERM (as sent by docker stop) won't shut it down and we have to wait for docker to time out and send SIGKILL. This is because cvmfsexec is pid 1 inside the container, which is special, and we have to have it explicitly forward the signals to the child processes. If we don't use cvmfsexec, then supervisord is pid 1, and signal propagation is handled. This commit adds `tini`, a small init system, to handle signal propagation; it is only used when we're using cvmfsexec.
rynge
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an issue where if the container uses cvmfsexec to mount repos, then a SIGTERM (as sent by docker stop) won't shut it down and we have to wait for docker to time out and send SIGKILL.
This is because cvmfsexec is pid 1 inside the container, which is special, and we have to have it explicitly forward the signals to the child processes. If we don't use cvmfsexec, then supervisord is pid 1, and signal propagation is handled.
This commit adds
tini, a small init system, to handle signal propagation; it is only used when we're using cvmfsexec.