Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RemoteException#getPartialSuccess #34

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

bryceatmoderne
Copy link
Contributor

@bryceatmoderne bryceatmoderne commented Sep 11, 2024

What's changed?

Added the field partialSuccess to RemoteException to indicate a command throwing an exception was partially successful.

What's your motivation?

The change provides finer granularity when reporting exit status of commands throwing RemoteException

Anything in particular you'd like reviewers to focus on?

Any potential backwards compatibility issues.

Anyone you would like to review specifically?

@timtebeek @sambsnyd

Have you considered any alternatives or workarounds?

No

Any additional context

No

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@bryceatmoderne bryceatmoderne self-assigned this Sep 11, 2024
@bryceatmoderne bryceatmoderne added the enhancement New feature or request label Sep 11, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/test/java/org/openrewrite/polyglot/RemoteExceptionTest.java
    • lines 74-74

@bryceatmoderne bryceatmoderne merged commit 2987307 into main Sep 12, 2024
2 checks passed
@bryceatmoderne bryceatmoderne deleted the add-remote-exception-partial-success branch September 12, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants