Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OpenResty 1.15.8.1, which now defaults to GC64 #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

philipp-classen
Copy link

@philipp-classen philipp-classen commented Jul 25, 2019

Disclaimer: I'm lacking understanding of the tools, but at least for a normal OpenResty installation on Ubuntu 18.04, it fixes the regression ("semantic error: unable to find member 'ptr32' for struct MRef") since the latest release for me.

refs #46

@agentzh
Copy link
Member

agentzh commented Aug 1, 2019

@philipp-classen This breaks compatibility with earlier OpenResty versions. We'll need to be smarter here.

@philipp-classen
Copy link
Author

@agentzh Yes, I'm sure you are right. As said, I'm lacking understanding of it and unfortunately I don't have the time to dig deeper.

We can close it. I still wanted to share it, maybe it helps someone out there who needs to profile the current version now and cannot wait. Until there is a proper fix, this hack might be useful.

@agentzh
Copy link
Member

agentzh commented Aug 1, 2019

We're actually retiring this repo (as well as the openresty-systemtap-toolkit repo and others) in favor of the upcoming OpenResty Trace platform (with will have free access for OpenResty open source users).

@soulbird
Copy link

maybe you can use --without-luajit-gc64 option that can force close gc64. And this just for debugging

@agentzh
Copy link
Member

agentzh commented Sep 22, 2020

@soulbird You can try OpenResty XRay which supports both GC64 and non-GC64 modes of LuaJIT. It provides a free trial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants