Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New theme for newsletter template #25

Merged
merged 27 commits into from
Aug 14, 2023
Merged

New theme for newsletter template #25

merged 27 commits into from
Aug 14, 2023

Conversation

antopalidi
Copy link
Member

@antopalidi antopalidi commented Aug 8, 2023

fixes #24

  • add config_accessor :themes
  • add new fields for capitalitat theme:
    • :intro_link_text
    • :intro_link_url
    • :footer_box_description_num
    • :footer_additional_text

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch coverage: 97.05% and project coverage change: +0.25% 🎉

Comparison is base (eb5f785) 97.02% compared to head (67bbd98) 97.28%.

❗ Current head 67bbd98 differs from pull request most recent head beb6cd7. Consider uploading reports for the commit beb6cd7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   97.02%   97.28%   +0.25%     
==========================================
  Files           5        5              
  Lines         202      221      +19     
==========================================
+ Hits          196      215      +19     
  Misses          6        6              
Files Changed Coverage Δ
lib/decidim/newsletter_agenda/engine.rb 97.56% <96.49%> (+0.30%) ⬆️
...ls/decidim/newsletter_agenda/agenda_events_cell.rb 94.87% <100.00%> (+0.42%) ⬆️
...sletter_agenda/agenda_events_settings_form_cell.rb 100.00% <100.00%> (ø)
lib/decidim/newsletter_agenda.rb 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@microstudi microstudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job. In the future maybe we will have to separate more the specific themes into different folders for admin too. For the moment it's ok

@microstudi microstudi merged commit 0c49839 into main Aug 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agenda Newsletter without background circle and with lines
2 participants