Solve #10, #11, add some additional features #12
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toObject
for runtime values (https://github.com/openpeeps/denim/pull/12/files#diff-86d904107e74d06b80c6f7718203ca025fec0ece6d8f39e2eeefa53877562214R226)hasOwnProperty
procedure (https://github.com/openpeeps/denim/pull/12/files#diff-86d904107e74d06b80c6f7718203ca025fec0ece6d8f39e2eeefa53877562214R316-R321)callFunction
proc (Calling callback JS functions in Nim #10) (https://github.com/openpeeps/denim/pull/12/files#diff-86d904107e74d06b80c6f7718203ca025fec0ece6d8f39e2eeefa53877562214R450)callMethod
proc (https://github.com/openpeeps/denim/pull/12/files#diff-86d904107e74d06b80c6f7718203ca025fec0ece6d8f39e2eeefa53877562214R455)export_napi
now works with Nim 2.0.0 (export_napi
not works with variables since Nim 2.0 #11) (https://github.com/openpeeps/denim/pull/12/files#diff-86d904107e74d06b80c6f7718203ca025fec0ece6d8f39e2eeefa53877562214R581-R601)napi_coerce_to...
(https://github.com/openpeeps/denim/pull/12/files#diff-86d904107e74d06b80c6f7718203ca025fec0ece6d8f39e2eeefa53877562214R722-R732)napi_get_property_names
(https://github.com/openpeeps/denim/pull/12/files#diff-86d904107e74d06b80c6f7718203ca025fec0ece6d8f39e2eeefa53877562214R735-R747)pairs
iterator fornapi_object
(https://github.com/openpeeps/denim/pull/12/files#diff-86d904107e74d06b80c6f7718203ca025fec0ece6d8f39e2eeefa53877562214R758-R762)$
nim proc (https://github.com/openpeeps/denim/pull/12/files#diff-86d904107e74d06b80c6f7718203ca025fec0ece6d8f39e2eeefa53877562214R770-R786)