-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change reference from open-next to @opennextjs/aws #529
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/opennextjs/opennextjs-aws/actions/runs/11139867869/job/30957412300?pr=529
You'll need to update the lockfile as well, otherwise it will fail the linting, and probably a bunch of other stuff
The build failed on The error was: Changing the Trying to revert the pnpm version now |
If there are different package versions across multiple apps, |
There's also: https://github.com/opennextjs/opennextjs-aws/blob/main/examples/app-router/package.json#L17C5-L17C32 |
Yeah but it should fail everywhere, not just on the example package. And keeping it on the old lockfile seems to do the trick |
I'm not even sure why there is a dep on |
Yea, I'm not sure why it's a dep either. A mistake a long time ago? The |
We can keep it for now, this would allow us to type the config file properly and maybe later add some custom adapter. |
Btw i think we should probably add a line here
I think right now it won't work with npx, we'll need to add "@opennextjs/aws": "./dist/index.js" We should keep the open-next one for compatibility for people who install open-next locally
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks!!
Hmm this is strange, did the folder structure change at all when this was migrated to the new org? |
@khuezy Found it it's the |
Great catch! Easy to miss that step, |
change reference from
open-next
to@opennextjs/aws
in everypackage.json
in the example repos. let me know if anything else needs to change.