Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/redirect protocol #451

Merged
merged 8 commits into from
Jun 28, 2024
Merged

Conversation

JanStevens
Copy link
Contributor

Fixes #450

Copy link

changeset-bot bot commented Jun 24, 2024

🦋 Changeset detected

Latest commit: 31665dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
open-next Patch
app-pages-router Patch
app-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jun 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
open-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2024 3:11pm

Copy link
Collaborator

@khuezy khuezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conico974
Copy link
Collaborator

We should add an e2e test for this as well, we could do an external redirect to the docs website for example

Copy link
Collaborator

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one also fail 2 test.
image

examples/app-router/next.config.js Outdated Show resolved Hide resolved
examples/pages-router/next.config.js Outdated Show resolved Hide resolved
@conico974 conico974 merged commit 208f7ba into opennextjs:main Jun 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirect to different domain result in invalid url
3 participants