Add Cache Support for [email protected]

[Manuel-Antunes]

Related Issue

#354

Proposed Changes

• create utils file overriding the cacheHander property

Changelog

• feat: add cache support for [email protected]
• fix: lint files

[changeset-bot]

🦋 Changeset detected

Latest commit: 4d4813d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
open-next	Patch
app-pages-router	Patch
app-router	Patch
tests-unit	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
open-next	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 1, 2024 10:40pm

[conico974]

I've added some comment, if you could change that.

[conico974]

The only things that change between 13.5.1+ and 14.1 is the ./14.1/utils.js
Could you refactor this to something like that

if (compareSemver(options.nextVersion, "13.5.1") >= 0) {
    const utilReplacement = compareSemver(options.nextVersion, "14.1.0") >= 0 ? "./14.1.util.js" : "./13.5/util.js"
    plugins = [
      openNextPlugin({
        name: "opennext-13.5-serverHandler",
        target: /plugins\/serverHandler\.js/g,
        replacements: ["./13.5/serverHandler.js"],
      }),
      openNextPlugin({
        name: "opennext-13.5-util",
        target: /plugins\/util\.js/g,
        replacements: [utilReplacement, "./util.replacement.js"],
      }),
      openNextPlugin({
        name: "opennext-13.5-default",
        target: /plugins\/routing\/default\.js/g,
        replacements: ["./default.replacement.js"],
      }),
    ];
  }

[Manuel-Antunes]

LGTM!

[conico974]

You don't need to create this file, just use the 13.5/serverHandler.js

[Manuel-Antunes]

I thought that the module resolution could find an error because the file isn't in the same directory so the relative path was supposed to be different

[conico974]

That's not how the plugin works https://open-next.js.org/inner_workings/plugin
Long story short, the only things that happens is that everything between //#override and //#endOverride is replaced in the files you provide

[conico974]

LGTM, i'll probably merge this by the end of the day

[Manuel-Antunes]

Awesome!