fix: fix response binary content handling (#526)

* fix response binary content headers * Create alacroix.md --------- Co-authored-by: conico974 <[email protected]>
opennextjs · Oct 3, 2024 · b5bfb5d · b5bfb5d
1 parent 9fceedb
commit b5bfb5d
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/.changeset/alacroix.md b/.changeset/alacroix.md
@@ -0,0 +1,5 @@
+---
+"@opennextjs/aws": patch
+---
+
+Fix response binary content handling
diff --git a/packages/open-next/src/core/routing/util.ts b/packages/open-next/src/core/routing/util.ts
@@ -76,11 +76,9 @@ export function convertRes(res: OpenNextNodeResponse): InternalResult {
   // When using HEAD requests, it seems that flushHeaders is not called, not sure why
   // Probably some kind of race condition
   const headers = parseHeaders(res.getFixedHeaders());
-  const isBase64Encoded = isBinaryContentType(
-    Array.isArray(headers["content-type"])
-      ? headers["content-type"][0]
-      : headers["content-type"],
-  );
+  const isBase64Encoded =
+    isBinaryContentType(headers["content-type"]) ||
+    !!headers["content-encoding"];
   // We cannot convert the OpenNextNodeResponse to a ReadableStream directly
   // You can look in the `aws-lambda.ts` file for some context
   const body = Readable.toWeb(Readable.from(res.getBody()));

diff --git a/packages/open-next/src/http/util.ts b/packages/open-next/src/http/util.ts
@@ -12,7 +12,7 @@ export const parseHeaders = (
     if (value === undefined) {
       continue;
     } else {
-      result[key] = convertHeader(value);
+      result[key.toLowerCase()] = convertHeader(value);
     }
   }