Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Add a check for customConceptAnswers when configuring coded person attribute fields #996

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

hiqedme
Copy link
Contributor

@hiqedme hiqedme commented Feb 22, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work is validated by existing tests.

Summary

This PR addresses an issue discovered while configuring the Patient Registration form. After adding customized concept answers to a patient attribute format org.openmrs.Concept, the error The person attribute field 'nextOfKinRelationship' is of type 'coded' but has been defined without an answer concept set UUID. The 'answerConceptSetUuid' key is required. is displayed. This has been resolved by adding customConceptAnswers to the check that determines whether the error should be shown.

Screenshots

Related Issue

N/A

Other

Error displayed should include customConceptAnswers

@denniskigen denniskigen changed the title fix/concept-answers: added customConceptAnswers check (fix/) Add a check for customConceptAnswers when configuring coded person attribute fields Feb 22, 2024
@denniskigen denniskigen changed the title (fix/) Add a check for customConceptAnswers when configuring coded person attribute fields (fix) Add a check for customConceptAnswers when configuring coded person attribute fields Feb 22, 2024
Copy link
Member

@donaldkibet donaldkibet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@donaldkibet donaldkibet merged commit 4d8ab44 into openmrs:main Feb 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants