(refactor) O3-2849: Refactor appointments mutator functions #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mogoodrich
commented
Feb 20, 2024
| @@ -3,7 +3,7 @@ import { type AppointmentPayload } from '../../types'; | |||
| import dayjs from 'dayjs'; | |||
| import { omrsDateFormat } from '../../constants'; | |||
|
|
|||
| // TODO we will refactor all this stuff to use the cancel functionality from patient-chart (or vice versa, but will move into the forms directory regardless) | |||
| // TODO we should refactor all this stuff to use the cancel functionality from patient-chart (or vice versa, but should move into the forms directory regardless) | |||
There was a problem hiding this comment.
Tangential tweak to a comment... :)
|
Size Change: -49.3 kB (-2%) Total Size: 2.96 MB
ℹ️ View Unchanged
|
mogoodrich
requested review from
denniskigen,
ibacher,
chibongho and
brandones
denniskigen
approved these changes
Feb 20, 2024
| ); | ||
|
|
||
| return { | ||
| mutate: mutateAppointments, |
There was a problem hiding this comment.
Nit: Might as well call this mutateAppointments to avoid aliasing the function name downstream.
denniskigen
changed the title
CynthiaKamau
approved these changes
Feb 21, 2024
|
Thanks all! Merging this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This refactors several of the mutator functions that get run when creating appointment records.
Screenshots
Related Issue
Other