Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) Chain tasks in the verify script and lower concurrency #988

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

denniskigen
Copy link
Member

@denniskigen denniskigen commented Feb 16, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR chains tasks in the verify script and lowers the concurrency of the task execution so a smaller percentage of the available logical processors is used. This should make it less likely that executing the script will slow down your computer.

Screenshots

Related Issue

Other

Copy link
Contributor

Size Change: 0 B

Total Size: 2.96 MB

ℹ️ View Unchanged
Filename Size
packages/esm-active-visits-app/dist/130.js 123 kB
packages/esm-active-visits-app/dist/255.js 2.21 kB
packages/esm-active-visits-app/dist/271.js 671 B
packages/esm-active-visits-app/dist/277.js 13.4 kB
packages/esm-active-visits-app/dist/316.js 42.9 kB
packages/esm-active-visits-app/dist/319.js 631 B
packages/esm-active-visits-app/dist/382.js 1.15 kB
packages/esm-active-visits-app/dist/448.js 47.1 kB
packages/esm-active-visits-app/dist/460.js 727 B
packages/esm-active-visits-app/dist/574.js 588 B
packages/esm-active-visits-app/dist/588.js 6.66 kB
packages/esm-active-visits-app/dist/635.js 1.15 kB
packages/esm-active-visits-app/dist/644.js 671 B
packages/esm-active-visits-app/dist/729.js 3.1 kB
packages/esm-active-visits-app/dist/757.js 649 B
packages/esm-active-visits-app/dist/784.js 2.63 kB
packages/esm-active-visits-app/dist/788.js 551 B
packages/esm-active-visits-app/dist/807.js 864 B
packages/esm-active-visits-app/dist/833.js 669 B
packages/esm-active-visits-app/dist/879.js 2.94 kB
packages/esm-active-visits-app/dist/main.js 65 kB
packages/esm-active-visits-app/dist/openmrs-esm-active-visits-app.js 3.33 kB
packages/esm-appointments-app/dist/130.js 123 kB
packages/esm-appointments-app/dist/152.js 257 B
packages/esm-appointments-app/dist/255.js 2.22 kB
packages/esm-appointments-app/dist/271.js 2.16 kB
packages/esm-appointments-app/dist/303.js 258 B
packages/esm-appointments-app/dist/319.js 1.99 kB
packages/esm-appointments-app/dist/388.js 48.9 kB
packages/esm-appointments-app/dist/426.js 271 kB
packages/esm-appointments-app/dist/460.js 2.18 kB
packages/esm-appointments-app/dist/500.js 2.52 kB
packages/esm-appointments-app/dist/574.js 1.85 kB
packages/esm-appointments-app/dist/588.js 6.65 kB
packages/esm-appointments-app/dist/591.js 16.9 kB
packages/esm-appointments-app/dist/644.js 2.16 kB
packages/esm-appointments-app/dist/729.js 3.1 kB
packages/esm-appointments-app/dist/757.js 1.75 kB
packages/esm-appointments-app/dist/784.js 2.63 kB
packages/esm-appointments-app/dist/788.js 1.75 kB
packages/esm-appointments-app/dist/807.js 2.4 kB
packages/esm-appointments-app/dist/833.js 1.99 kB
packages/esm-appointments-app/dist/main.js 323 kB
packages/esm-appointments-app/dist/openmrs-esm-appointments-app.js 3.33 kB
packages/esm-patient-list-management-app/dist/130.js 123 kB
packages/esm-patient-list-management-app/dist/255.js 2.21 kB
packages/esm-patient-list-management-app/dist/271.js 1.33 kB
packages/esm-patient-list-management-app/dist/295.js 99.3 kB
packages/esm-patient-list-management-app/dist/319.js 1.53 kB
packages/esm-patient-list-management-app/dist/382.js 1.15 kB
packages/esm-patient-list-management-app/dist/435.js 22.7 kB
packages/esm-patient-list-management-app/dist/460.js 1.73 kB
packages/esm-patient-list-management-app/dist/574.js 1.34 kB
packages/esm-patient-list-management-app/dist/588.js 6.66 kB
packages/esm-patient-list-management-app/dist/591.js 16.9 kB
packages/esm-patient-list-management-app/dist/635.js 1.15 kB
packages/esm-patient-list-management-app/dist/644.js 1.31 kB
packages/esm-patient-list-management-app/dist/716.js 4.66 kB
packages/esm-patient-list-management-app/dist/729.js 3.1 kB
packages/esm-patient-list-management-app/dist/757.js 1.51 kB
packages/esm-patient-list-management-app/dist/784.js 2.64 kB
packages/esm-patient-list-management-app/dist/788.js 1.34 kB
packages/esm-patient-list-management-app/dist/807.js 1.84 kB
packages/esm-patient-list-management-app/dist/833.js 1.6 kB
packages/esm-patient-list-management-app/dist/main.js 126 kB
packages/esm-patient-list-management-app/dist/openmrs-esm-patient-list-management-app.js 3.3 kB
packages/esm-patient-registration-app/dist/130.js 123 kB
packages/esm-patient-registration-app/dist/152.js 262 B
packages/esm-patient-registration-app/dist/209.js 36.4 kB
packages/esm-patient-registration-app/dist/255.js 2.21 kB
packages/esm-patient-registration-app/dist/271.js 1.6 kB
packages/esm-patient-registration-app/dist/303.js 260 B
packages/esm-patient-registration-app/dist/319.js 1.99 kB
packages/esm-patient-registration-app/dist/460.js 2.03 kB
packages/esm-patient-registration-app/dist/537.js 2.34 kB
packages/esm-patient-registration-app/dist/574.js 1.7 kB
packages/esm-patient-registration-app/dist/591.js 16.9 kB
packages/esm-patient-registration-app/dist/62.js 6.86 kB
packages/esm-patient-registration-app/dist/644.js 1.6 kB
packages/esm-patient-registration-app/dist/729.js 3.1 kB
packages/esm-patient-registration-app/dist/730.js 115 kB
packages/esm-patient-registration-app/dist/735.js 464 B
packages/esm-patient-registration-app/dist/757.js 2.07 kB
packages/esm-patient-registration-app/dist/784.js 2.64 kB
packages/esm-patient-registration-app/dist/788.js 1.63 kB
packages/esm-patient-registration-app/dist/807.js 2.43 kB
packages/esm-patient-registration-app/dist/833.js 1.97 kB
packages/esm-patient-registration-app/dist/879.js 2.94 kB
packages/esm-patient-registration-app/dist/884.js 6.1 kB
packages/esm-patient-registration-app/dist/main.js 153 kB
packages/esm-patient-registration-app/dist/openmrs-esm-patient-registration-app.js 3.34 kB
packages/esm-patient-search-app/dist/130.js 123 kB
packages/esm-patient-search-app/dist/152.js 261 B
packages/esm-patient-search-app/dist/255.js 2.21 kB
packages/esm-patient-search-app/dist/271.js 1.01 kB
packages/esm-patient-search-app/dist/303.js 260 B
packages/esm-patient-search-app/dist/319.js 1.03 kB
packages/esm-patient-search-app/dist/382.js 1.15 kB
packages/esm-patient-search-app/dist/460.js 1.16 kB
packages/esm-patient-search-app/dist/48.js 26.3 kB
packages/esm-patient-search-app/dist/574.js 910 B
packages/esm-patient-search-app/dist/588.js 6.66 kB
packages/esm-patient-search-app/dist/591.js 16.9 kB
packages/esm-patient-search-app/dist/635.js 1.15 kB
packages/esm-patient-search-app/dist/644.js 1.02 kB
packages/esm-patient-search-app/dist/710.js 22.8 kB
packages/esm-patient-search-app/dist/729.js 3.1 kB
packages/esm-patient-search-app/dist/757.js 1.02 kB
packages/esm-patient-search-app/dist/784.js 2.63 kB
packages/esm-patient-search-app/dist/788.js 788 B
packages/esm-patient-search-app/dist/807.js 1.25 kB
packages/esm-patient-search-app/dist/833.js 1.06 kB
packages/esm-patient-search-app/dist/main.js 52.2 kB
packages/esm-patient-search-app/dist/openmrs-esm-patient-search-app.js 3.34 kB
packages/esm-service-queues-app/dist/130.js 123 kB
packages/esm-service-queues-app/dist/152.js 262 B
packages/esm-service-queues-app/dist/255.js 2.23 kB
packages/esm-service-queues-app/dist/271.js 3.11 kB
packages/esm-service-queues-app/dist/303.js 261 B
packages/esm-service-queues-app/dist/319.js 3.14 kB
packages/esm-service-queues-app/dist/328.js 3.08 kB
packages/esm-service-queues-app/dist/389.js 2.42 kB
packages/esm-service-queues-app/dist/425.js 2.06 kB
packages/esm-service-queues-app/dist/460.js 3.96 kB
packages/esm-service-queues-app/dist/574.js 3.19 kB
packages/esm-service-queues-app/dist/581.js 156 kB
packages/esm-service-queues-app/dist/588.js 6.66 kB
packages/esm-service-queues-app/dist/591.js 16.9 kB
packages/esm-service-queues-app/dist/616.js 2.71 kB
packages/esm-service-queues-app/dist/621.js 55 kB
packages/esm-service-queues-app/dist/644.js 3.06 kB
packages/esm-service-queues-app/dist/694.js 2.64 kB
packages/esm-service-queues-app/dist/729.js 3.1 kB
packages/esm-service-queues-app/dist/757.js 3.13 kB
packages/esm-service-queues-app/dist/784.js 2.63 kB
packages/esm-service-queues-app/dist/788.js 3.12 kB
packages/esm-service-queues-app/dist/807.js 4.36 kB
packages/esm-service-queues-app/dist/833.js 3.62 kB
packages/esm-service-queues-app/dist/981.js 2.93 kB
packages/esm-service-queues-app/dist/main.js 214 kB
packages/esm-service-queues-app/dist/openmrs-esm-service-queues-app.js 3.31 kB

compressed-size-action

@brandones brandones merged commit 4f49e0a into main Feb 18, 2024
6 checks passed
@brandones brandones deleted the chore/remove-max-concurrency-from-verify-task branch February 18, 2024 04:07
@mogoodrich
Copy link
Member

Oh, this is awesome, running verify was really clogging resources, and it was almost impossible to push from with IntelliJ because the verify basically crashed IntelliJ, thanks @denniskigen

@denniskigen
Copy link
Member Author

If resource usage is still a concern, we could just remove the concurrency flag altogether. Let me know how things go, @mogoodrich.

@ibacher
Copy link
Member

ibacher commented Feb 21, 2024

we could just remove the concurrency flag altogether

Removed, it defaults to 10. It might be nice if we could do something like --concurrency=1 and then in CI --concurrency=100%.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants