(fix) O3 2804: Reuse ResponsiveWrapper component from esm-framework #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@denniskigen can you also review this |
denniskigen
changed the title
denniskigen
approved these changes
Feb 22, 2024
denniskigen
added a commit
to himanshu-malviya15/openmrs-esm-patient-management
that referenced
this pull request
Feb 22, 2024
…penmrs#985) * fix:Removed instances of ResponsiveWrapper with the component from the framework * Bump esm-framework and openmrs tooling * Refactor some more occurences --------- Co-authored-by: Dennis Kigen <[email protected]>
denniskigen
added a commit
to himanshu-malviya15/openmrs-esm-patient-management
that referenced
this pull request
Feb 26, 2024
…penmrs#985) * fix:Removed instances of ResponsiveWrapper with the component from the framework * Bump esm-framework and openmrs tooling * Refactor some more occurences --------- Co-authored-by: Dennis Kigen <[email protected]>
denniskigen
added a commit
that referenced
this pull request
Feb 26, 2024
#989) * (fix) O3 2804: Reuse ResponsiveWrapper component from esm-framework (#985) * fix:Removed instances of ResponsiveWrapper with the component from the framework * Bump esm-framework and openmrs tooling * Refactor some more occurences --------- Co-authored-by: Dennis Kigen <[email protected]> * Fix: appointment-service-hook restBaseUrl * Fixup --------- Co-authored-by: Dennis Kigen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Replace all the instances of 'ResponsiveWrapper' with the component present in esm-framework, also removed all the custom ResponsiveWrapper, also removed unused Layer component imports.
Related Issue
03-2804