-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(test) O3-2722: Add E2E test for returning to home page and patient list page from the patient chart #957
Conversation
…e from the patient chart
29efc48
to
d9bc61e
Compare
a843ae0
to
d157c85
Compare
…e from the patient chart
@jayasanka-sack this PR is waiting review. Thanks |
@vasharma05 @denniskigen @brandones could you review this PR? Thanks. |
Where'd @jayasanka-sack go? |
Hi @Piumal1999 @jayasanka-sack, please review this PR. |
Hey, I'm so sorry I missed this. Let me have a look. |
Hey Daud, kudos on getting the steps implemented! I've got a suggestion to make things even more organized: create a new spec with the following:
@kdaud @brandones let me know what you think |
@jayasanka-sack I would suggest to break the test into the suggested cases without creating a new spec file since they're concerning with patient list. I'm open to suggestion. |
The reason for new spec is that it calls for different pre-populated data, meaning we'll need different 'Given' statements. That also means we'll have to set up new 'beforeEach' and 'afterEach' hooks. |
@jayasanka-sack I've addressed the suggestion. Could you review the changes? thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much, Daud! I added few minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a bunch, @kdaud !
Requirements
Summary
Screenshots
Related Issue
https://issues.openmrs.org/browse/O3-2722
Other