Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) Enable reverse order for name fields in registration form via configuration #744

Merged
merged 6 commits into from
Jul 3, 2023
Merged

(feat) Enable reverse order for name fields in registration form via configuration #744

merged 6 commits into from
Jul 3, 2023

Conversation

vasharma05
Copy link
Member

@vasharma05 vasharma05 commented Jun 28, 2023 •
edited by denniskigen
Loading

Requirements

Summary

Adds a configuration property, displayReverseFieldOrder, that determines whether to display fields of the name section of the registration form in reverse order. When set to true, the name fields get ordered as Family name -> Middle name -> First name.

When set to false, the default order First name -> Middle name -> Family name is maintained.

Configuration point:

"@openmrs/esm-patient-registration-app": {
  "fieldConfigurations": {
    "name": {
      displayReverseFieldOrder: boolean
    }
  }
}

Screenshots

image

Related Issue

None.

Other

None.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 28, 2023 •
edited
Loading

Size Change: +97 B (0%)

Total Size: 2.12 MB

ℹ️ View Unchanged
Filename Size Change
packages/esm-active-visits-app/dist/130.js 131 kB 0 B
packages/esm-active-visits-app/dist/316.js 42.9 kB 0 B
packages/esm-active-visits-app/dist/319.js 548 B 0 B
packages/esm-active-visits-app/dist/574.js 548 B 0 B
packages/esm-active-visits-app/dist/588.js 6.66 kB 0 B
packages/esm-active-visits-app/dist/629.js 7.48 kB 0 B
packages/esm-active-visits-app/dist/757.js 640 B 0 B
packages/esm-active-visits-app/dist/784.js 2.63 kB 0 B
packages/esm-active-visits-app/dist/788.js 546 B 0 B
packages/esm-active-visits-app/dist/807.js 860 B 0 B
packages/esm-active-visits-app/dist/833.js 665 B 0 B
packages/esm-active-visits-app/dist/842.js 881 B 0 B
packages/esm-active-visits-app/dist/879.js 2.94 kB 0 B
packages/esm-active-visits-app/dist/909.js 54.2 kB 0 B
packages/esm-active-visits-app/dist/936.js 7.93 kB 0 B
packages/esm-active-visits-app/dist/main.js 3.39 kB 0 B
packages/esm-active-visits-app/dist/openmrs-esm-active-visits-app.js 3.22 kB 0 B
packages/esm-appointments-app/dist/130.js 131 kB 0 B
packages/esm-appointments-app/dist/319.js 1.73 kB 0 B
packages/esm-appointments-app/dist/328.js 11.4 kB 0 B
packages/esm-appointments-app/dist/381.js 10.5 kB 0 B
packages/esm-appointments-app/dist/437.js 2.44 kB 0 B
packages/esm-appointments-app/dist/456.js 661 B 0 B
packages/esm-appointments-app/dist/469.js 6.65 kB 0 B
packages/esm-appointments-app/dist/574.js 1.72 kB 0 B
packages/esm-appointments-app/dist/591.js 16.9 kB 0 B
packages/esm-appointments-app/dist/610.js 6.71 kB 0 B
packages/esm-appointments-app/dist/738.js 144 kB 0 B
packages/esm-appointments-app/dist/752.js 30.9 kB 0 B
packages/esm-appointments-app/dist/757.js 1.73 kB 0 B
packages/esm-appointments-app/dist/781.js 103 kB 0 B
packages/esm-appointments-app/dist/784.js 2.63 kB 0 B
packages/esm-appointments-app/dist/788.js 1.73 kB 0 B
packages/esm-appointments-app/dist/80.js 5.09 kB 0 B
packages/esm-appointments-app/dist/807.js 2.42 kB 0 B
packages/esm-appointments-app/dist/833.js 2.02 kB 0 B
packages/esm-appointments-app/dist/884.js 1.96 kB 0 B
packages/esm-appointments-app/dist/main.js 5.49 kB 0 B
packages/esm-appointments-app/dist/openmrs-esm-appointments-app.js 3.18 kB 0 B
packages/esm-outpatient-app/dist/119.js 27.6 kB 0 B
packages/esm-outpatient-app/dist/121.js 3.99 kB 0 B
packages/esm-outpatient-app/dist/130.js 131 kB 0 B
packages/esm-outpatient-app/dist/176.js 5.94 kB 0 B
packages/esm-outpatient-app/dist/242.js 218 B 0 B
packages/esm-outpatient-app/dist/252.js 2.21 kB 0 B
packages/esm-outpatient-app/dist/286.js 2.88 kB 0 B
packages/esm-outpatient-app/dist/308.js 8.14 kB 0 B
packages/esm-outpatient-app/dist/319.js 3.06 kB 0 B
packages/esm-outpatient-app/dist/328.js 3.1 kB 0 B
packages/esm-outpatient-app/dist/330.js 8.61 kB 0 B
packages/esm-outpatient-app/dist/364.js 2.02 kB 0 B
packages/esm-outpatient-app/dist/425.js 3.43 kB 0 B
packages/esm-outpatient-app/dist/457.js 2.49 kB 0 B
packages/esm-outpatient-app/dist/469.js 6.65 kB 0 B
packages/esm-outpatient-app/dist/521.js 2.74 kB 0 B
packages/esm-outpatient-app/dist/53.js 3.14 kB 0 B
packages/esm-outpatient-app/dist/574.js 3.08 kB 0 B
packages/esm-outpatient-app/dist/591.js 16.9 kB 0 B
packages/esm-outpatient-app/dist/610.js 6.71 kB 0 B
packages/esm-outpatient-app/dist/611.js 2.64 kB 0 B
packages/esm-outpatient-app/dist/616.js 3.59 kB 0 B
packages/esm-outpatient-app/dist/644.js 1.24 kB 0 B
packages/esm-outpatient-app/dist/670.js 155 kB 0 B
packages/esm-outpatient-app/dist/733.js 4.09 kB 0 B
packages/esm-outpatient-app/dist/757.js 3.06 kB 0 B
packages/esm-outpatient-app/dist/764.js 5.25 kB 0 B
packages/esm-outpatient-app/dist/766.js 4.73 kB 0 B
packages/esm-outpatient-app/dist/784.js 2.63 kB 0 B
packages/esm-outpatient-app/dist/788.js 3.06 kB 0 B
packages/esm-outpatient-app/dist/807.js 4.43 kB 0 B
packages/esm-outpatient-app/dist/833.js 3.66 kB 0 B
packages/esm-outpatient-app/dist/86.js 4.42 kB 0 B
packages/esm-outpatient-app/dist/981.js 2.91 kB 0 B
packages/esm-outpatient-app/dist/main.js 3.96 kB 0 B
packages/esm-outpatient-app/dist/openmrs-esm-outpatient-app.js 3.19 kB 0 B
packages/esm-patient-list-app/dist/130.js 131 kB 0 B
packages/esm-patient-list-app/dist/255.js 4.4 kB 0 B
packages/esm-patient-list-app/dist/294.js 3.29 kB 0 B
packages/esm-patient-list-app/dist/319.js 943 B 0 B
packages/esm-patient-list-app/dist/404.js 4.36 kB 0 B
packages/esm-patient-list-app/dist/469.js 95.9 kB 0 B
packages/esm-patient-list-app/dist/537.js 534 B 0 B
packages/esm-patient-list-app/dist/563.js 15.4 kB 0 B
packages/esm-patient-list-app/dist/574.js 942 B 0 B
packages/esm-patient-list-app/dist/588.js 6.66 kB 0 B
packages/esm-patient-list-app/dist/591.js 16.9 kB 0 B
packages/esm-patient-list-app/dist/716.js 4.62 kB 0 B
packages/esm-patient-list-app/dist/757.js 1.09 kB 0 B
packages/esm-patient-list-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-list-app/dist/788.js 941 B 0 B
packages/esm-patient-list-app/dist/791.js 1.72 kB 0 B
packages/esm-patient-list-app/dist/807.js 1.37 kB 0 B
packages/esm-patient-list-app/dist/833.js 1.13 kB 0 B
packages/esm-patient-list-app/dist/900.js 7.66 kB 0 B
packages/esm-patient-list-app/dist/main.js 6.08 kB 0 B
packages/esm-patient-list-app/dist/openmrs-esm-patient-list-app.js 3.18 kB 0 B
packages/esm-patient-registration-app/dist/130.js 131 kB 0 B
packages/esm-patient-registration-app/dist/167.js 27.2 kB +43 B (0%)
packages/esm-patient-registration-app/dist/177.js 57.2 kB 0 B
packages/esm-patient-registration-app/dist/294.js 23.4 kB 0 B
packages/esm-patient-registration-app/dist/319.js 1.36 kB 0 B
packages/esm-patient-registration-app/dist/537.js 3.74 kB 0 B
packages/esm-patient-registration-app/dist/574.js 1.43 kB 0 B
packages/esm-patient-registration-app/dist/591.js 16.9 kB 0 B
packages/esm-patient-registration-app/dist/62.js 6.86 kB 0 B
packages/esm-patient-registration-app/dist/635.js 456 B 0 B
packages/esm-patient-registration-app/dist/68.js 9.51 kB +52 B (+1%)
packages/esm-patient-registration-app/dist/735.js 464 B 0 B
packages/esm-patient-registration-app/dist/742.js 721 B 0 B
packages/esm-patient-registration-app/dist/757.js 1.7 kB 0 B
packages/esm-patient-registration-app/dist/784.js 2.64 kB 0 B
packages/esm-patient-registration-app/dist/788.js 1.36 kB 0 B
packages/esm-patient-registration-app/dist/807.js 2.16 kB 0 B
packages/esm-patient-registration-app/dist/833.js 1.66 kB 0 B
packages/esm-patient-registration-app/dist/857.js 2.08 kB 0 B
packages/esm-patient-registration-app/dist/9.js 12.2 kB 0 B
packages/esm-patient-registration-app/dist/947.js 28.9 kB 0 B
packages/esm-patient-registration-app/dist/975.js 425 B 0 B
packages/esm-patient-registration-app/dist/main.js 21.8 kB +2 B (0%)
packages/esm-patient-registration-app/dist/openmrs-esm-patient-registration-app.js 3.19 kB 0 B
packages/esm-patient-search-app/dist/110.js 16.4 kB 0 B
packages/esm-patient-search-app/dist/128.js 2.02 kB 0 B
packages/esm-patient-search-app/dist/130.js 131 kB 0 B
packages/esm-patient-search-app/dist/319.js 757 B 0 B
packages/esm-patient-search-app/dist/327.js 1.05 kB 0 B
packages/esm-patient-search-app/dist/439.js 1.6 kB 0 B
packages/esm-patient-search-app/dist/44.js 3.55 kB 0 B
packages/esm-patient-search-app/dist/519.js 4.56 kB 0 B
packages/esm-patient-search-app/dist/531.js 5.58 kB 0 B
packages/esm-patient-search-app/dist/574.js 769 B 0 B
packages/esm-patient-search-app/dist/575.js 29.4 kB 0 B
packages/esm-patient-search-app/dist/588.js 6.66 kB 0 B
packages/esm-patient-search-app/dist/591.js 16.9 kB 0 B
packages/esm-patient-search-app/dist/757.js 899 B 0 B
packages/esm-patient-search-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-search-app/dist/788.js 753 B 0 B
packages/esm-patient-search-app/dist/807.js 1.1 kB 0 B
packages/esm-patient-search-app/dist/833.js 913 B 0 B
packages/esm-patient-search-app/dist/842.js 2.06 kB 0 B
packages/esm-patient-search-app/dist/main.js 3.45 kB 0 B
packages/esm-patient-search-app/dist/openmrs-esm-patient-search-app.js 3.19 kB 0 B

compressed-size-action

denniskigen
denniskigen approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Vineet.

@denniskigen denniskigen changed the title (feat) Display family name before the first name as per configuration (feat) Enable reverse order for name fields in registration form via configuration Jul 3, 2023
@denniskigen denniskigen merged commit fbf58c3 into main Jul 3, 2023
7 checks passed
@denniskigen denniskigen deleted the swap-given-family-name-fields branch July 3, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denniskigen denniskigen denniskigen approved these changes

@ibacher ibacher Awaiting requested review from ibacher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vasharma05 @denniskigen